Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation notice on the question edit screen on PHP 8.1 #7645

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Fix deprecation notice on the question edit screen on PHP 8.1 #7645

merged 3 commits into from
Jul 30, 2024

Conversation

m1r0
Copy link
Member

@m1r0 m1r0 commented Jul 29, 2024 •
edited
Loading

Part of #7634

Proposed Changes

  • Fix the deprecation notice on the question edit screen on PHP 8.1.

image

Testing Instructions

  1. Use PHP 8.1.
  2. Add define( 'WP_DEBUG_DISPLAY', true ); in wp-config.php.
  3. Go to Sensei LMS -> Questions and select any question.
  4. There should be no deprecation notice.
  5. The "Quizzes" section should be working as before.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@m1r0 m1r0 added this to the 4.24.2 milestone Jul 29, 2024
@m1r0 m1r0 self-assigned this Jul 29, 2024
@m1r0 m1r0 marked this pull request as ready for review July 29, 2024 13:12
@m1r0 m1r0 requested a review from a team July 29, 2024 13:12
@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@merkushin merkushin requested review from merkushin and removed request for a team July 30, 2024 00:30
merkushin
merkushin approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@merkushin merkushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thanks!

@m1r0 m1r0 merged commit a03be8b into trunk Jul 30, 2024
23 checks passed
@m1r0 m1r0 deleted the fix/deprecation-notice-on-question-edit-screen branch July 30, 2024 08:46
@donnapep donnapep linked an issue Aug 2, 2024 that may be closed by this pull request
Test Sensei and Sensei Pro on PHP 8.1 #7634
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merkushin merkushin merkushin approved these changes

Assignees

@m1r0 m1r0

Labels
None yet
Projects
None yet
Milestone
4.24.2
Development

Successfully merging this pull request may close these issues.

Test Sensei and Sensei Pro on PHP 8.1
2 participants
@m1r0 @merkushin