Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Page becomes unresponsive after seeing an offer #3574

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fix: Page becomes unresponsive after seeing an offer #3574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
927736b
fix page becomes unresponsive after seeing an offer
mebarbosa Feb 10, 2025
f26428b
update CHANGELOG.md
mebarbosa Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
([#3546](https://github.com/Automattic/pocket-casts-android/pull/3546))
* Fix Media Notification artwork caching issues
([#3566](https://github.com/Automattic/pocket-casts-android/pull/3566))
* Fix issue causing the Account Details page to become unresponsive after viewing an offer
([#3574](https://github.com/Automattic/pocket-casts-android/pull/3574))
* Updates
* Filter out chapters that do not belong in table of contents. See [the specification](https://github.com/Podcastindex-org/podcast-namespace/blob/main/chapters/jsonChapters.md) for more details.
([#3556](https://github.com/Automattic/pocket-casts-android/pull/3556))
Expand Down
9 changes: 9 additions & 0 deletions ...n/java/au/com/shiftyjelly/pocketcasts/account/onboarding/upgrade/OnboardingUpgradeFlow.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,15 @@ fun OnboardingUpgradeFlow(
}
}

LaunchedEffect(sheetState.currentValue) {
// We need to check if the screen was initialized with the expanded state.
// Otherwise, the sheet will never be shown since the initial state is Hidden.
// This will trigger this event, and onBackPressed will be called.
if (sheetState.currentValue == ModalBottomSheetValue.Hidden && startSelectPaymentFrequencyInExpandedState) {
onBackPressed()
}
}

BackHandler {
if (sheetState.isVisible) {
coroutineScope.launch { sheetState.hide() }
Expand Down