Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Page becomes unresponsive after seeing an offer #3574

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fix: Page becomes unresponsive after seeing an offer #3574

merged 2 commits into from
Feb 11, 2025

Conversation

mebarbosa
Copy link
Contributor

@mebarbosa mebarbosa commented Feb 10, 2025 •
edited
Loading

Description

  • Fix the unresponsive issue after seeing the upgrade modal bottom sheet

Fixes #3462

Testing Instructions

See the issue's video here: #3462

Issue

  1. Log in with free account
  2. Go to Profile -> Account
  3. Tap on Subscribe button
  4. See the upgrade modal bottom sheet
  5. Tap out of the modal to close it
  6. Ensure you can interact with the screen ✅
  7. Open the modal again
  8. Press device back button
  9. Ensure you can interact with the screen ✅

Smoke test

Smoke test the paywalls, open the paywalls from different sources and ensure they continue working as expected ✅

Screenshots or Screencast

Screen_recording_20250210_143727.webm

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@mebarbosa mebarbosa added [Type] Bug Not functioning as intended. [Area] Subscriptions Plus or Patron issue labels Feb 10, 2025
@mebarbosa mebarbosa added this to the 7.83 milestone Feb 10, 2025
@mebarbosa mebarbosa requested a review from a team as a code owner February 10, 2025 17:45
@mebarbosa mebarbosa requested review from MiSikora and removed request for a team February 10, 2025 17:45
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 10, 2025 •
edited
Loading

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commitf26428b
Direct Downloadpocketcasts-app-prototype-build-pr3574-f26428b.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commitf26428b
Direct Downloadpocketcasts-automotive-prototype-build-pr3574-f26428b.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commitf26428b
Direct Downloadpocketcasts-wear-prototype-build-pr3574-f26428b.apk

@mebarbosa mebarbosa merged commit ff27ef8 into main Feb 11, 2025
17 checks passed
@mebarbosa mebarbosa deleted the fix/unresponsive-page-after-seeing-offer branch February 11, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiSikora MiSikora MiSikora approved these changes

Assignees
No one assigned
Labels
[Area] Subscriptions Plus or Patron issue [Type] Bug Not functioning as intended.
Projects
None yet
Milestone
7.83
Development

Successfully merging this pull request may close these issues.

Account Details page becomes unresponsive after seeing an offer
3 participants
@mebarbosa @wpmobilebot @MiSikora