Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Fix incorrect call to copy_branch_protection #3563

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

AliSoftware
Copy link
Contributor

Fix syntax error in the PR #3562 I just landed.

I shouldn't have trusted Cursor's autocomplete suggestion… 🤦

I shouldn't have trusted Cursor's autocomplete suggestion…
@AliSoftware AliSoftware added [Type] Tooling Related to the Gradle build scripts and the setup or maintenance of the project build process. [Area] Tooling labels Feb 6, 2025
@AliSoftware AliSoftware added this to the 7.83 milestone Feb 6, 2025
@AliSoftware AliSoftware requested review from MiSikora and a team February 6, 2025 19:49
@AliSoftware AliSoftware self-assigned this Feb 6, 2025
@AliSoftware AliSoftware requested a review from a team as a code owner February 6, 2025 19:49
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 6, 2025

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit2c0f4e7
Direct Downloadpocketcasts-app-prototype-build-pr3563-2c0f4e7.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit2c0f4e7
Direct Downloadpocketcasts-automotive-prototype-build-pr3563-2c0f4e7.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit2c0f4e7
Direct Downloadpocketcasts-wear-prototype-build-pr3563-2c0f4e7.apk

@AliSoftware AliSoftware enabled auto-merge (squash) February 6, 2025 19:52
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shouldn't have trusted Cursor's autocomplete suggestion… 🤦

It's an artificial intern. Trust but verify.

Besides, we can blame this to Ruby, too. In a compiled language, we would haven known about it locally.

On the note of trust but verify, I looked at the generated docs just in case and it all checks

image

@AliSoftware AliSoftware merged commit acc021f into main Feb 6, 2025
18 of 20 checks passed
@AliSoftware AliSoftware deleted the tooling/release-branch-protection branch February 6, 2025 20:11
@AliSoftware
Copy link
Contributor Author

I shouldn't have trusted Cursor's autocomplete suggestion… 🤦

It's an artificial intern. Trust but verify.

💯 . On me for not verifying it more carefully

Besides, we can blame this to Ruby, too. In a compiled language, we would haven known about it locally.

💯

On the note of trust but verify, I looked at the generated docs just in case and it all checks

I also just tested it by commenting all the lines in the code_freeze lane except new_version = release_version_current and the call to this copy_branch_protection. I then ran the lane and confirmed that not only it passed without crashing, but that the branch protection settings for the release/7.82 branch now include the CI required checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] Tooling [Type] Tooling Related to the Gradle build scripts and the setup or maintenance of the project build process.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants