[Tooling] Protect the release/* branch with the same settings as main
#3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And in particular enabling the required CI checks on PRs targeting the release branch too
AliSoftware
added
[Type] Tooling
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
MiSikora
approved these changes
Feb 6, 2025
AliSoftware
commented
Feb 6, 2025
| # restrictions we have in `main`, and the release managers wouldn't be able to push due to permissions. | ||
| # This should be changed only when we have PC Android releases done on CI, when the CI bot is the one running `git push`. | ||
| set_branch_protection(repository: GITHUB_REPO, branch: "release/#{new_version}") | ||
| copy_branch_protection(repository: GITHUB_REPO, branch: "release/#{new_version}", from_branch: DEFAULT_BRANCH) |
There was a problem hiding this comment.
Shoot, that's not the name of the parameters expected by that action… I shouldn't have trusted Cursor's autocomplete suggestion 😓
Fix in #3563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During code freeze and after the creation of the new
release/*branch, replaces the call toset_branch_protectionwithcopy_branch_protectioninstead, so that it replicates the same branch protections as the ones set on themainbranch.In particular, this will require the same CI checks on PRs targeting the
release/*branch than the ones set for themainbranch