[Suggested Folder] Create suggested folder screen UI #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
mebarbosa
commented
Feb 5, 2025
Comment on lines
58
to
62
| Column( | ||
| modifier = Modifier | ||
| .padding(horizontal = 16.dp) | ||
| .padding(bottom = 16.dp), | ||
| ) { |
There was a problem hiding this comment.
I created this column to put the close icon out and increase its touch area
mebarbosa
commented
Feb 5, 2025
| count = folders, | ||
| key = { index -> index }, | ||
| ) { index -> | ||
| FolderItem("Test", Color.Yellow, podcastUuids) |
There was a problem hiding this comment.
I am mocking the folders for this PR to see the folders on screen
10 tasks
geekygecko
approved these changes
Feb 6, 2025
...casts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/folders/SuggestedFolders.kt
Show resolved
Hide resolved
...s/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/folders/SuggestedFoldersPage.kt
Show resolved
Hide resolved
...s/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/folders/SuggestedFoldersPage.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3549
Testing Instructions
Screenshots or Screencast
Screen_recording_20250205_093219.webm
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...