[Suggested Folder] Create suggested folder screen UI #3554
+260
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
mebarbosa
commented
Feb 5, 2025
| } | ||
|
|
||
| @Composable | ||
| private fun Folders(podcastUuids: List<String>, modifier: Modifier = Modifier) { |
There was a problem hiding this comment.
When this PR got merged I will refactor this common part
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
MiSikora
reviewed
Feb 6, 2025
|
|
||
| @Composable | ||
| private fun Folders(podcastUuids: List<String>, modifier: Modifier = Modifier) { | ||
| val folders = 3 |
There was a problem hiding this comment.
Is there a need for this val?
| private fun Folders(podcastUuids: List<String>, modifier: Modifier = Modifier) { | ||
| val folders = 3 | ||
|
|
||
| LazyVerticalGrid( |
There was a problem hiding this comment.
I might be missing something by why use LazyVerticalGrid over a Row?
| savedInstanceState: Bundle?, | ||
| ) = contentWithoutConsumedInsets { | ||
| AppTheme(theme.activeTheme) { | ||
| SuggestedFoldersPaywall( |
There was a problem hiding this comment.
We should handle window insets and not draw the content behind the camera punch hole.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3553
Testing Instructions
Screenshots or Screencast
Screen_recording_20250205_151647.webm
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...