Fix missing episodes with unfollowed podcasts

CHANGELOG.md

@@ -1,6 +1,8 @@
 7.83
 -----
-
+*   Bug Fixes
+    *   Fix missing episodes with unfollowed podcasts
+        ([#3546](https://github.com/Automattic/pocket-casts-android/pull/3546))
 
 7.82
 -----

modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/podcast/PodcastManagerImpl.kt

@@ -37,9 +37,9 @@ import io.reactivex.Flowable
 import io.reactivex.Maybe
 import io.reactivex.Single
 import io.reactivex.schedulers.Schedulers
-import java.util.Calendar
 import javax.inject.Inject
 import kotlin.coroutines.CoroutineContext
+import kotlin.time.Duration.Companion.days
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.delay
@@ -224,25 +224,36 @@ class PodcastManagerImpl @Inject constructor(
 
         // we don't delete podcasts added to the phone in the last week. This is to prevent stuff you just leave open in discover from being removed
         val addedDate = podcast.addedDate
-        val calendar = Calendar.getInstance()
-        calendar.add(Calendar.DAY_OF_YEAR, -7)
-        val oneWeekAgo = calendar.time
-        if (addedDate != null && addedDate > oneWeekAgo) {
+        val oneWeekAgoMs = System.currentTimeMillis() - 7.days.inWholeMilliseconds
+        if (addedDate != null && addedDate.time > oneWeekAgoMs) {
             return false
         }
 
         // podcasts can be deleted if all of the episodes are haven't been interacted with
         val episodes = episodeManager.findEpisodesByPodcastOrderedBlocking(podcast)
         var podcastHasChangedEpisodes = false
+        var latestPlaybackInteraction = 0L
         val deleteEpisodes = mutableListOf<PodcastEpisode>()
         for (episode in episodes) {
+            // find the latest playback interaction
+            episode.lastPlaybackInteraction?.let { interaction ->
+                if (interaction > latestPlaybackInteraction) {
+                    latestPlaybackInteraction = interaction
+                }
+            }
+            // don't delete the podcast if any of the episodes have been interacted with
             if (episodeManager.userHasInteractedWithEpisode(episode, playbackManager)) {
                 podcastHasChangedEpisodes = true
                 continue
             }
             // bulk delete or it takes 10 seconds on a large podcast
             deleteEpisodes.add(episode)
         }
+        // don't delete the episodes or podcast if the latest playback interaction happening in the last month
+        val oneMonthAgoMs = System.currentTimeMillis() - 30.days.inWholeMilliseconds
+        if (latestPlaybackInteraction > oneMonthAgoMs) {
+            return false
+        }
         if (deleteEpisodes.isNotEmpty()) {
             episodeManager.deleteEpisodesWithoutSyncBlocking(deleteEpisodes, playbackManager)
         }

modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/sync/PodcastRefresherImpl.kt

@@ -28,7 +28,8 @@ class PodcastRefresherImpl @Inject constructor(
     override suspend fun refreshPodcast(existingPodcast: Podcast, playbackManager: PlaybackManager) {
         try {
             val podcastResponse = cacheServiceManager.getPodcastResponse(existingPodcast.uuid)
-            if (podcastResponse.wasCached() || podcastResponse.notModified()) {
+            // unsubscribed podcasts have episodes removed, so always refresh them
+            if (existingPodcast.isSubscribed && (podcastResponse.wasCached() || podcastResponse.notModified())) {
                 LogBuffer.i(LogBuffer.TAG_BACKGROUND_TASKS, "Refreshing podcast ${existingPodcast.uuid} not required as cached")
                 return
             }