Fix missing episodes with unfollowed podcasts #3546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
geekygecko
added
[Type] Bug
geekygecko
commented
Feb 6, 2025
| val oneWeekAgo = calendar.time | ||
| if (addedDate != null && addedDate > oneWeekAgo) { | ||
| val oneWeekAgoMs = System.currentTimeMillis() - 7.days.inWholeMilliseconds | ||
| if (addedDate != null && addedDate.time > oneWeekAgoMs) { |
There was a problem hiding this comment.
This doesn't change any logic it only simplifies the code.
geekygecko
force-pushed
the
task/fix-missing-episodes
branch
from
91e9be0 to
ec56b5d
Compare
mebarbosa
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Internal reference p1738686765061199-slack-C02A333D8LQ
There's an issue that if:
It won’t delete the podcast from your database but will delete all the other episodes you haven’t interacted with. If the user goes back to the podcast page the episodes won't be added back to the podcast.
Testing Instructions
To be able to repeat this issue you need to make the following code change as it only happens to podcasts added over a week ago.
Screenshots
Example of the issue:
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...