Skip to content

Forms: Fix submit button loading spinner not showing #46913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CGastrell merged 3 commits into from
Feb 3, 2026
Merged

Forms: Fix submit button loading spinner not showing #46913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ea4124
Forms: Fix submit button loading spinner selector
CGastrell Feb 2, 2026
defaf99
Add changelog entry
CGastrell Feb 2, 2026
d8af4d5
use simple classes to sselect the button to show loading state
CGastrell Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/forms/changelog/fix-submit-button-loading-state
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Contact Form: Fix loading spinner not showing on submit button.
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry uses 'Contact Form' as a prefix. According to the changelog guidelines, entries in the forms package should not use the package name as a prefix. Remove the 'Contact Form:' prefix.

Copilot generated this review using guidance from repository custom instructions.
4 changes: 2 additions & 2 deletions projects/packages/forms/src/contact-form/css/grunion.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1510,8 +1510,8 @@ on production builds, the attributes are being reordered, causing side-effects
}

// use new ::after approach for animated spinner inside forms
.contact-form .wp-block-jetpack-form-step-navigation .wp-block-jetpack-button:last-of-type button[type="submit"].is-submitting,
.contact-form .wp-block-jetpack-form-step-navigation .wp-block-button:last-of-type button[type="submit"].is-submitting {
.contact-form .wp-block-jetpack-button .is-submitting:not(.disable-spinner),
.contact-form .wp-block-button .is-submitting:not(.disable-spinner) {

&::after {

Expand Down
Loading