Skip to content

Conversation

@CGastrell
Copy link
Contributor

Proposed changes:

  • Fix the CSS selector for the submit button loading spinner to apply to all submit buttons within contact forms, not just those within step navigation blocks

Other information:

The previous selector .contact-form .wp-block-jetpack-form-step-navigation .wp-block-jetpack-button:last-of-type button[type="submit"].is-submitting was too specific and only applied the loading spinner styles when the submit button was inside a step navigation block. This change broadens the selector to apply to any submit button in a contact form.

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  1. Create a Jetpack Form block without step navigation
  2. Add a submit button
  3. Submit the form
  4. Verify the loading spinner appears on the submit button while the form is being submitted

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings February 2, 2026 21:29
@CGastrell CGastrell added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Package] Forms Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR labels Feb 2, 2026
@CGastrell CGastrell self-assigned this Feb 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a CSS selector issue that prevented the loading spinner from appearing on submit buttons in contact forms that don't use step navigation.

Changes:

  • Modified the CSS selector to remove the .wp-block-jetpack-form-step-navigation specificity requirement
  • Added a changelog entry documenting the fix

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
projects/packages/forms/src/contact-form/css/grunion.scss Broadened CSS selector to apply loading spinner styles to all submit buttons in contact forms
projects/packages/forms/changelog/fix-submit-button-loading-state Added changelog entry for the bug fix

Significance: patch
Type: fixed

Contact Form: Fix loading spinner not showing on submit button.
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry uses 'Contact Form' as a prefix. According to the changelog guidelines, entries in the forms package should not use the package name as a prefix. Remove the 'Contact Form:' prefix.

Copilot generated this review using guidance from repository custom instructions.
Copy link
Member

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected for me!

CGastrell and others added 3 commits February 2, 2026 17:43
Broaden the CSS selector to apply loading spinner styles to all submit
buttons, not just those within step navigation.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@enejb enejb force-pushed the fix/forms-submit-button-loading-state branch from 723be2d to d8af4d5 Compare February 3, 2026 01:43
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/forms-submit-button-loading-state branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/forms-submit-button-loading-state

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Coverage check overridden by Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR .

@CGastrell CGastrell merged commit 86786c8 into trunk Feb 3, 2026
70 checks passed
@CGastrell CGastrell deleted the fix/forms-submit-button-loading-state branch February 3, 2026 14:29
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR [Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants