-
Notifications
You must be signed in to change notification settings - Fork 853
Forms: Fix submit button loading spinner not showing #46913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a CSS selector issue that prevented the loading spinner from appearing on submit buttons in contact forms that don't use step navigation.
Changes:
- Modified the CSS selector to remove the
.wp-block-jetpack-form-step-navigationspecificity requirement - Added a changelog entry documenting the fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/packages/forms/src/contact-form/css/grunion.scss | Broadened CSS selector to apply loading spinner styles to all submit buttons in contact forms |
| projects/packages/forms/changelog/fix-submit-button-loading-state | Added changelog entry for the bug fix |
| Significance: patch | ||
| Type: fixed | ||
|
|
||
| Contact Form: Fix loading spinner not showing on submit button. |
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry uses 'Contact Form' as a prefix. According to the changelog guidelines, entries in the forms package should not use the package name as a prefix. Remove the 'Contact Form:' prefix.
enejb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected for me!
Broaden the CSS selector to apply loading spinner styles to all submit buttons, not just those within step navigation. Co-Authored-By: Claude Opus 4.5 <[email protected]>
723be2d to
d8af4d5
Compare
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
Proposed changes:
Other information:
The previous selector
.contact-form .wp-block-jetpack-form-step-navigation .wp-block-jetpack-button:last-of-type button[type="submit"].is-submittingwas too specific and only applied the loading spinner styles when the submit button was inside a step navigation block. This change broadens the selector to apply to any submit button in a contact form.Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
No
Testing instructions:
🤖 Generated with Claude Code