Connection: protected owner class

[bindlegirl]

Related to: VULCAN-86
P2: pghT6q-3V-p2

Proposed changes:

• Created a class for errors related to missing protected owner i.e., the WP.com plan owners
• Class checks for the existence of an error option (created remotely) and based on it assembles the error array for displaying error in Jetpack dashboard and My Jetpack.
• Error is deleted when required user is created.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• This needs to be tested with Connection: protected owner errors manual fix #43593, which handles the frontend part.
• Use Beta tester plugin to load this PR for the wpcomsh plugin and load the other PR for Jetpack plugin.
• When you have both PRs loaded in Beta, use cli to create an error for an account that doesn't exist wp option update jetpack_connection_protected_owner_error --format=json '{"error_type":"missing_owner","email":"[email protected]","timestamp":1747835900}'
• Check dashboard and My Jetpack, make sure error is there
• Create the missing account. Make sure the error is gone.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the add/protected_owner_error_wpcomsh branch.

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Wpcomsh plugin:

• Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/wpcomsh/wpcomsh.php	110/321 (34.27%)	-0.11%	1 ❤️‍🩹

Full summary · PHP report

[bindlegirl]

@fgiannar As we discussed, I'm clearing all xmlrpc errors now for WoA sites and leaving only protected owner ones if they exist.

[fgiannar]

Amazing work, Ana!

Thank you for working on this and applying all the suggested recommendations 👍

I followed the test instructions and can confirm that I didn't see any Connection errors apart from the missing site owner error, which immediately went away after creating the corresponding local user.

I also made sure to test this without the Jetpack counterpart PR to simulate the period between updating wpcomsh and the Jetpack plugin in WP Cloud. I can confirm nothing breaks in this case too.

Tested with an existing broken Connection too using the Broken Token functionality via the Jetpack Debug Tools plugin. I didn't see any errors as expected.

[fgiannar]

I wonder if we could simplify the logic for disabling the invites by taking advantage of the jetpack_sso_invite_new_users_wpcom SSO filter

Setting this to false will prevent all the additional SSO related fields from being displayed at the new user form. Noting that those are only rendered if the current user is connected, so this way we ensure that they won't be rendered anyways.

[fgiannar]

LGTM 👍

Made sure to test adding the missing user both as a connected and non-connected admin and can confirm it works as expected:
In all cases the invite checkbox is not present and email and role inputs are pre-populated with the WPCOM site owner email and administrator role.