Connection: protected owner errors manual fix

[bindlegirl]

Related to: VULCAN-86
P2: pghT6q-3V-p2

Proposed changes:

• Adding filter to Error_Handler class so wpcomsh can plug in with Protected owner errors.
• Adapted js components to handle protected owner errors and display a different button that redirects users to account creation.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Testing instructions in Connection: protected owner class #43601

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add/protected_owner_error_manual branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/protected_owner_error_manual

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/protected_owner_error_manual

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jp-launch-control]

Code Coverage Summary

Coverage changed in 6 files. Only the first 5 are listed here.

File	Coverage	Δ%	Δ Uncovered
projects/js-packages/connection/hooks/use-connection-error-notice/index.jsx	9/36 (25.00%)	25.00%	18 💔
projects/plugins/jetpack/_inc/client/components/jetpack-notices/jetpack-connection-errors.jsx	2/21 (9.52%)	-3.81%	6 💔
projects/js-packages/connection/components/connection-error-notice/index.jsx	2/18 (11.11%)	11.11%	4 💔
projects/js-packages/connection/hooks/use-restore-connection/index.jsx	1/23 (4.35%)	4.35%	-1 💚
projects/packages/my-jetpack/_inc/hooks/use-notification-watcher/use-connection-errors-notice.tsx	26/27 (96.30%)	96.30%	-17 💚

Full summary · PHP report · JS report

_{If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.}

[fgiannar]

This is what I see when I create the missing user manually:

I was testing with a secondary non-connected admin. I was under the impression that we only display errors for the current user when the error has user_id set. Isn't this the case?

[bindlegirl]

I have cleared all the errors in the other PR and updated error messages for the React dashboard so that only the protected owner gets a custom message. I have also updated the My Jetpack code to follow the updated logic and not depend on error messages.

[fgiannar]

Amazing work, Ana!

Thank you for working on this and applying all the suggested recommendations 👍

I followed the test instructions and can confirm that I didn't see any Connection errors apart from the missing site owner error, which immediately went away after creating the corresponding local user.

[bindlegirl]

Hey @fgiannar, I made some changes to the JS files so they make more sense 🤞
Could you take this PR for one more ride?