Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed race conditioning inside indices_boundary_masker due to duplicate corner and edge indices #72

Closed
wants to merge 173 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
173 commits
Select commit Hold shift + click to select a range
b3acb4a
xlb refactor
loliverhennigh Dec 15, 2023
034ee36
Merge pull request #28 from loliverhennigh/backend_exposure
mehdiataei Dec 15, 2023
1c8e75c
Added pyc to gitignore
mehdiataei Dec 16, 2023
9fc7d20
Refactoring backend initiation and data structure: collison and eq done.
mehdiataei Jan 10, 2024
c0b30fc
small LBM example for functional programing
loliverhennigh Jan 23, 2024
bcd57f5
Merge pull request #31 from loliverhennigh/functional_lbm_implementation
hsalehipour Jan 25, 2024
a05441f
example_mehdi works with no error
mehdiataei Jan 26, 2024
71c952b
Added multi-GPU support and mlups computation
mehdiataei Jan 29, 2024
78e9536
Merge pull request #32 from mehdiataei/major-refactoring
mehdiataei Jan 29, 2024
2d8eb57
Added inline
mehdiataei Feb 5, 2024
a48510c
Added pallas but there is a shape issue yet
mehdiataei Feb 6, 2024
b4e13c6
first restructuring
loliverhennigh Feb 6, 2024
02fcbf5
almost finished bc
loliverhennigh Feb 13, 2024
6f35f02
almost finished
loliverhennigh Feb 14, 2024
18a13b8
structure fully in
loliverhennigh Feb 16, 2024
3d1245e
almost done
loliverhennigh Feb 21, 2024
93a130d
almost done
loliverhennigh Feb 21, 2024
05b87bf
stepper almost working
loliverhennigh Feb 22, 2024
9ebf244
parralization
loliverhennigh Feb 22, 2024
299c3cc
stepper functional
loliverhennigh Feb 28, 2024
6cb085a
Merge pull request #37 from loliverhennigh/warp_backend
mehdiataei Feb 28, 2024
cb8459c
fixed warp bug
loliverhennigh Feb 29, 2024
15c47f6
Merge pull request #38 from loliverhennigh/warp_backend
mehdiataei Feb 29, 2024
b62bab1
first commit
loliverhennigh Mar 7, 2024
5263007
bad merge
loliverhennigh Mar 7, 2024
7560115
Merge branch 'major-refactoring' of github.com:Autodesk/XLB into boun…
loliverhennigh Mar 7, 2024
414047d
boundary condition restructuring
loliverhennigh Mar 7, 2024
c715b69
base boundary condition structure
loliverhennigh Mar 11, 2024
9a29639
added boundar condition example
loliverhennigh Mar 25, 2024
5c4732f
LDC example
loliverhennigh Mar 26, 2024
0387247
Working!
loliverhennigh Mar 29, 2024
18abd12
Finalized changes
loliverhennigh Mar 30, 2024
d4d67b9
Merge pull request #40 from loliverhennigh/boundary_conditions
mehdiataei Mar 30, 2024
94fd5f0
added kbc
loliverhennigh Apr 8, 2024
ca969af
Merge pull request #41 from loliverhennigh/kbc_warp
mehdiataei Apr 8, 2024
6836b09
Fixed boundaries and added conformance test.
mehdiataei Apr 9, 2024
19e93c0
Added tests for grid and equilibrium kernels
mehdiataei Apr 22, 2024
e33827a
WIP added tests for all main kernels + changes to operator + 2D kerne…
mehdiataei Apr 25, 2024
d37aa1e
WIP: Added lots of tests and fixed a bunch of errors
mehdiataei May 6, 2024
0534eb0
WIP added more tests
mehdiataei May 10, 2024
b4b825e
WIP added JAX planar masker and test is passing
mehdiataei May 10, 2024
f62d06c
WIP warp test for planar masker is passing now. Mask part is left for…
mehdiataei May 10, 2024
96759e9
WIP: Added more tests for planar masker
mehdiataei May 10, 2024
c05c0e8
Added half-way. Not tested yet.
mehdiataei May 28, 2024
2d0aa5f
Added trackback to the error.
mehdiataei May 28, 2024
66a9fc2
Refactoring done (single-GPU). Multi-GPU will be pushed soon.
mehdiataei May 30, 2024
b36b053
WIP distribute function. Warp backend closure issues are mostly fixe…
mehdiataei Jun 18, 2024
346b2e5
Fixed distributed errors and added mlups 3D
mehdiataei Jun 27, 2024
4c5b1c2
Fixed bugs + wind tunnel and flow over sphere examples
mehdiataei Jun 28, 2024
179ae0b
Fixed a minor bug for JAX backend
mehdiataei Jun 28, 2024
a10e4a8
Added KBC and wind tunnel at high Re
mehdiataei Jun 28, 2024
327b19f
WIP: testing a new way of setting up BCs
hsalehipour Jul 12, 2024
6be3495
Fixed a few bugs. JAX works. Need to look into Warp next
hsalehipour Jul 15, 2024
3a9a97e
Warp working with the new BC setup
hsalehipour Jul 16, 2024
9b9b184
converting the example script to be class-based
hsalehipour Jul 16, 2024
1b31ccf
updated all examples to run properly
hsalehipour Jul 16, 2024
f42f245
All pytest unit tests pass now!
hsalehipour Jul 16, 2024
83abb38
addressing comments during the PR review and more clean-up
hsalehipour Jul 19, 2024
fc87b9b
Merge pull request #49 from hsalehipour/test_new_bc_setup
mehdiataei Jul 19, 2024
6f7397e
Removed the need to pass sharding_flag in for distributed workload
mehdiataei Jul 29, 2024
987d136
Merge pull request #51 from mehdiataei/major-refactoring
mehdiataei Jul 30, 2024
e2616bd
somewhat improved bc handling using structs
hsalehipour Jul 30, 2024
8c2bc40
minor clean up. Warp MLUPs is not affected.
hsalehipour Jul 30, 2024
d6e265d
modified BC kernels kernels in warp to resemble jax and also NSE kern…
hsalehipour Jul 31, 2024
50cc016
Fixed precision policy properties
mehdiataei Aug 1, 2024
59407ea
Merge branch 'Autodesk:major-refactoring' into major-refactoring
mehdiataei Aug 1, 2024
9822d4f
Removed deprecated sharding_flags
mehdiataei Aug 1, 2024
d7b35b3
Merge pull request #53 from mehdiataei/major-refactoring
hsalehipour Aug 2, 2024
a9f35fc
WIP: fixing missing mask in both jax and warp
hsalehipour Aug 2, 2024
1b17945
WIP: making the signature of all BC functional consistent in Warp
hsalehipour Aug 2, 2024
a2ec3a2
fix a bug in the latest jax implementation of indices_masker
hsalehipour Aug 2, 2024
1810e9c
Fixed distribute and post processing bugs
mehdiataei Aug 2, 2024
0da352b
Merge pull request #54 from mehdiataei/major-refactoring
hsalehipour Aug 2, 2024
aeb1770
Added ruff
mehdiataei Aug 2, 2024
e07976e
Merge pull request #55 from mehdiataei/major-refactoring
hsalehipour Aug 2, 2024
9375832
Merge branch 'refactoring-origin' into refactoring-hesam
hsalehipour Aug 2, 2024
d55a438
added missing ruff formatting
hsalehipour Aug 2, 2024
2d4f6d6
Merge branch 'fix_missingMask' into missingMask
hsalehipour Aug 2, 2024
329bd4c
Warp structs (#56)
hsalehipour Aug 2, 2024
5fa63f5
major improvements to Warp impl of BC. all consistent now.
hsalehipour Aug 3, 2024
67d7a19
major improvements to Warp impl of BC. all consistent now.
hsalehipour Aug 4, 2024
27e5d66
Merge branch 'missingMask' into major-refactoring
hsalehipour Aug 4, 2024
025c28e
ZouHe BC added in JAX
hsalehipour Aug 7, 2024
0539f61
Merge pull request #57 from hsalehipour/major-refactoring
mehdiataei Aug 8, 2024
90969d1
added some warp helper functions in the BoundaryCondition class to re…
hsalehipour Aug 7, 2024
4c6d7d5
added ZouHe in warp
hsalehipour Aug 9, 2024
310aa37
added a new macroscopic operator to compute second moments
hsalehipour Aug 14, 2024
18368d8
Merge pull request #58 from hsalehipour/RegularizedBC
mehdiataei Aug 14, 2024
9fe1a61
fixed a subtle bug in ZouHe (JAX)
hsalehipour Aug 15, 2024
12b5f3d
WIP: regularized initial commit
hsalehipour Aug 15, 2024
4b230cb
improving the call to BC functionals in Warp
hsalehipour Aug 15, 2024
3f0cda3
fixed a nasty bug with struct type
hsalehipour Aug 15, 2024
0ddfb2b
fixed a really gnarly bug in ZouHe (Warp)
hsalehipour Aug 16, 2024
398092d
Regularized (JAX) works!
hsalehipour Aug 16, 2024
3d54ffa
some cleanup and rearrangement
hsalehipour Aug 16, 2024
b15bb05
Regularized (Warp) also completed and verified!
hsalehipour Aug 16, 2024
4cecd27
consistent naming for Moments. Macroscopic is now an alias for zeroth…
hsalehipour Aug 18, 2024
76597d4
used lax.broadcast_in_dim instead of jnp.repeat plus other minor changes
hsalehipour Aug 20, 2024
9232ace
Merge pull request #59 from hsalehipour/RegularizedBC
hsalehipour Aug 20, 2024
77f17ca
minor bugs
hsalehipour Aug 20, 2024
f83dcce
WIP: extrapolation outflow bc initial commit
hsalehipour Aug 20, 2024
b20b2af
Extrapolation outflow BC added in Warp
hsalehipour Aug 21, 2024
c3db21c
added ExtrapolationOutflow (JAX)
hsalehipour Aug 26, 2024
25fbef8
corrected the extrapolation BC but MLUPS drop of 12%
hsalehipour Aug 26, 2024
8a4c7cd
fixed the performance issue. All great now!
hsalehipour Aug 26, 2024
d178de3
Merge branch 'correct_ExtrapolationOutflow_Warp' into dev
hsalehipour Aug 26, 2024
14051ce
fixed minor syntax bugs
hsalehipour Aug 26, 2024
2cd61fd
minor refactoring
hsalehipour Aug 26, 2024
fbcf525
weird nan bug in Reg/Zouhe fixed. Python pointer issue!
hsalehipour Aug 27, 2024
91c706a
modified the sequence of lbm step operators in JAX to match stream-th…
hsalehipour Aug 27, 2024
c0e3117
WIP: initial commit for force computation using momentum exchange method
hsalehipour Aug 27, 2024
23dd4e0
WIP: using stl_boundary_masker for reading STL geometries
hsalehipour Aug 27, 2024
47a5f26
renamed boundary_mask to boundary_map
hsalehipour Aug 27, 2024
1db3242
WIP: changed mesh_boundary_masker and used it in the wind tunnel example
hsalehipour Aug 28, 2024
8a2255f
applied changes requested in the PR review
hsalehipour Aug 29, 2024
31895f9
Merge branch 'PR_review' into dev
hsalehipour Aug 29, 2024
18c8ee5
mesh_boundary_masker working as expected and added to the wind tunnel…
hsalehipour Aug 29, 2024
0adb6f7
added drag and force calculation to the windtunnel example.
hsalehipour Aug 29, 2024
74bd907
Merge pull request #60 from hsalehipour/dev
mehdiataei Aug 29, 2024
60aad2e
now indices_boundary_masker also handles boundary geometries in the i…
hsalehipour Aug 30, 2024
f16c4b9
Merge branch 'stl_handling' into dev
hsalehipour Aug 30, 2024
2a3e6c6
Fixing the syntax error in Warp when bc list is empty. When empty, pe…
hsalehipour Aug 30, 2024
fe8c945
Merge pull request #61 from hsalehipour/dev
mehdiataei Sep 5, 2024
7a7399d
fixing the issue for cases where internal geometry contacts the domai…
hsalehipour Sep 6, 2024
431b855
minor renaming for clarity
hsalehipour Sep 6, 2024
721dc0e
renaming boundary_map to bc_id
hsalehipour Sep 9, 2024
aaff2c3
added exact difference forcing scheme
hsalehipour Sep 9, 2024
d96a394
ported the benchmark example of turbulent channel flow.
hsalehipour Sep 10, 2024
e21780e
Removed the need to have separate JAX/Warp constants
mehdiataei Sep 13, 2024
fd759d3
Renamed _c32
mehdiataei Sep 13, 2024
9a37ab3
Renamed _c32
mehdiataei Sep 13, 2024
db392f1
Removed instances of fp32
mehdiataei Sep 13, 2024
2fd397e
Merge branch 'major-refactoring' of https://github.com/mehdiataei/XLB…
mehdiataei Sep 13, 2024
e2028cb
Operators work in fp64 and fp64 with no issues
mehdiataei Sep 13, 2024
a396328
Merge pull request #62 from mehdiataei/major-refactoring
hsalehipour Sep 13, 2024
e8a9a88
Merge branch 'major-refactoring' into dev
hsalehipour Sep 16, 2024
b85ab6a
fixing merge issues
hsalehipour Sep 16, 2024
a7de4bb
resolved all unit test issues
hsalehipour Sep 16, 2024
1fa7ad6
fixed dtype issues for fp64
hsalehipour Sep 16, 2024
d6db85d
used numpy instead of lists for finding boundingBox indices
hsalehipour Sep 16, 2024
29aa3a2
renaming to bc_mask
hsalehipour Sep 16, 2024
3ff0814
Merge pull request #63 from hsalehipour/dev
mehdiataei Sep 18, 2024
c4c994b
Separated zero and first kernels
mehdiataei Sep 19, 2024
e6de337
Deleted old file
mehdiataei Sep 20, 2024
448883f
Changed rho type
mehdiataei Sep 20, 2024
834da9a
Merge pull request #65 from mehdiataei/major-refactoring
hsalehipour Sep 20, 2024
6eca3f2
Merge branch 'main' of https://github.com/mehdiataei/XLB into major-r…
mehdiataei Sep 23, 2024
9496f6f
Fixed mixed-precision for Warp
mehdiataei Sep 24, 2024
60e95f7
Merge pull request #67 from mehdiataei/major-refactoring
hsalehipour Sep 24, 2024
53910bc
minor renaming
hsalehipour Sep 26, 2024
b913f35
WIP: adding boundary_distance for curved and moving boundaries
hsalehipour Sep 26, 2024
8cfbd50
storing mesh distance in f_0
hsalehipour Sep 29, 2024
9cb6bf3
renaming file
hsalehipour Sep 29, 2024
cc09003
WIP: reformulated Grads BC
hsalehipour Sep 30, 2024
6e32706
major improvement to BC functionals and nse_stepper
hsalehipour Oct 1, 2024
8c0fe1d
finalizing reformulated Grads BC
hsalehipour Oct 1, 2024
0448d2b
fixed out-of-bound issues and added large bc_id for skipping lbm on …
hsalehipour Oct 2, 2024
ad33b3e
adding a flag to assert mesh distance masker is used for bc_grads
hsalehipour Oct 2, 2024
9748480
fixing some remaining type issues
hsalehipour Oct 3, 2024
eb26a59
Finalized a novel hybrid interpolated bounceback and regularized bc f…
hsalehipour Oct 3, 2024
0dbe840
added necessary changes to the nse_stepper
hsalehipour Oct 3, 2024
371dfd8
added not implemented error for 2d settings
hsalehipour Oct 3, 2024
a18eea4
Merge branch 'GradApprox' into major-refactoring
hsalehipour Oct 3, 2024
96d80f0
fixed ruff issue and commented out the perf drop lines
hsalehipour Oct 3, 2024
0f912d4
enabled the new BC to work with indices bc masker
hsalehipour Oct 4, 2024
f215c5b
added recent changes to the momentum exchange method
hsalehipour Oct 4, 2024
a786ccd
missed from prev commit
hsalehipour Oct 4, 2024
a50fbbd
Merge pull request #68 from hsalehipour/major-refactoring
mehdiataei Oct 5, 2024
1d1560b
Significantly simplified boundary application
mehdiataei Oct 6, 2024
d73a6d6
Fixed zouhe and regularized bcs but there are limitations in applying…
mehdiataei Oct 7, 2024
0123748
Extremely simplified BC implementation!
mehdiataei Oct 8, 2024
3843188
Merge pull request #69 from mehdiataei/major-refactoring
hsalehipour Oct 8, 2024
e16ba24
fixed race conditioning in indices_boundary_masker due to duplicate b…
hsalehipour Oct 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Lint

on:
pull_request:
branches:
- major-refactoring # Remember to add main branch later

jobs:
lint:
runs-on: ubuntu-latest

steps:
- name: Check out code
uses: actions/checkout@v2

- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.11'

- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install ruff

- name: Run Ruff
run: ruff check .
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Thumbs.db
__pycache__/
*.py[cod]
*$py.class

**pyc
# C extensions
*.so

Expand Down
6 changes: 6 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.5.6
hooks:
- id: ruff
args: [--fix]
195 changes: 0 additions & 195 deletions examples/CFD/airfoil3d.py

This file was deleted.

96 changes: 0 additions & 96 deletions examples/CFD/cavity2d.py

This file was deleted.

Loading
Loading