Fixed race conditioning inside indices_boundary_masker due to duplicate corner and edge indices #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lementation small LBM example for functional programing
Major refactoring
fixed warp bug
Separated zero and first moment kernels
Fixed mixed-precision for Warp
…or stationary and moving BCs
A stable and robust BC added for stationary and moving curved BCs
… the same bc type multiple times
Significantly simplified boundary condition application in the stepper
…c indices at corners and edges.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When boundary conditions instances have common indices for instance at edges and corners, there was a race conditioning in indices boundary masker and the resultant bc_id for boundary voxels were not consistently correct.