-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exoplanet Forcing & Banning #19373
base: master
Are you sure you want to change the base?
Exoplanet Forcing & Banning #19373
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -83,6 +83,10 @@ | |
///A list of groups, as strings, that this exoplanet belongs to. When adding new map templates, try to keep this balanced on the CI execution time, or consider adding a new one | ||
///ONLY IF IT'S THE LONGEST RUNNING CI POD AND THEY ARE ALREADY BALANCED | ||
var/list/unit_test_groups = list() | ||
///For mutually exclusive exoplanet types | ||
var/list/banned_exoplanets = list() | ||
///For guaranteed exoplanet types | ||
var/list/guaranteed_exoplanets = list() | ||
Comment on lines
+86
to
+89
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same thing here, and also put it near the |
||
|
||
|
||
/obj/effect/overmap/visitable/sector/exoplanet/proc/generate_habitability() | ||
|
@@ -181,7 +185,7 @@ | |
#if defined(UNIT_TEST) | ||
if((SSunit_tests_config.config["exoplanets_ruins"] == FALSE) || ((SSunit_tests_config.config["exoplanets_ruins"] != TRUE) && !(T in SSunit_tests_config.config["exoplanets_ruins"]))) | ||
if(!shown_warning_for_exoplanets_ruins_config && (SSunit_tests_config.config["exoplanets_ruins"] == FALSE)) | ||
LOG_GITHUB_WARNING("Not spawning ruins for [src.name] because 'exoplanets_ruins' is FALSE in the UT config") | ||
Check warning on line 188 in code/modules/overmap/exoplanets/exoplanet.dm GitHub Actions / Run Ruins Tests (runtime, ruins-3)
Check warning on line 188 in code/modules/overmap/exoplanets/exoplanet.dm GitHub Actions / Run Ruins Tests (runtime, ruins-3)
Check warning on line 188 in code/modules/overmap/exoplanets/exoplanet.dm GitHub Actions / Run Ruins Tests (runtime, ruins-1)
Check warning on line 188 in code/modules/overmap/exoplanets/exoplanet.dm GitHub Actions / Run Ruins Tests (runtime, ruins-1)
Check warning on line 188 in code/modules/overmap/exoplanets/exoplanet.dm GitHub Actions / Run Ruins Tests (runtime, ruins-2)
|
||
shown_warning_for_exoplanets_ruins_config = TRUE | ||
|
||
LOG_GITHUB_DEBUG("Ruin [T] for [src.name] not spawned because either 'exoplanets_ruins' is FALSE or it does not contain it in the UT config") | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
################################ | ||
# Example Changelog File | ||
# | ||
# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb. | ||
# | ||
# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.) | ||
# When it is, any changes listed below will disappear. | ||
# | ||
# Valid Prefixes: | ||
# bugfix | ||
# - (fixes bugs) | ||
# wip | ||
# - (work in progress) | ||
# qol | ||
# - (quality of life) | ||
# soundadd | ||
# - (adds a sound) | ||
# sounddel | ||
# - (removes a sound) | ||
# rscadd | ||
# - (adds a feature) | ||
# rscdel | ||
# - (removes a feature) | ||
# imageadd | ||
# - (adds an image or sprite) | ||
# imagedel | ||
# - (removes an image or sprite) | ||
# spellcheck | ||
# - (fixes spelling or grammar) | ||
# experiment | ||
# - (experimental change) | ||
# balance | ||
# - (balance changes) | ||
# code_imp | ||
# - (misc internal code change) | ||
# refactor | ||
# - (refactors code) | ||
# config | ||
# - (makes a change to the config files) | ||
# admin | ||
# - (makes changes to administrator tools) | ||
# server | ||
# - (miscellaneous changes to server) | ||
################################# | ||
|
||
# Your name. | ||
author: RustingWithYou | ||
|
||
# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. | ||
delete-after: True | ||
|
||
# Any changes you've made. See valid prefix list above. | ||
# INDENT WITH TWO SPACES. NOT TABS. SPACES. | ||
# SCREW THIS UP AND IT WON'T WORK. | ||
# Also, this gets changed to [] after reading. Just remove the brackets when you add new shit. | ||
# Please surround your changes in double quotes ("). It works without them, but if you use certain characters it screws up compiling. The quotes will not show up in the changelog. | ||
changes: | ||
- qol: "Exoplanets can now prevent or force other exoplanets to spawn." | ||
- qol: "Away sites can now force or ban exoplanets from spawning." |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,10 @@ | |
/// Should be assoc map of `/turf/unsimulated/marker/...` path to `/datum/exoplanet_theme/...` path, | ||
/// where exoplanet generation with the map value is applied only on marker turfs of the applicable map key. | ||
var/list/exoplanet_themes = null | ||
///Exoplanets that this site will force to spawn. Useful for on-planet away sites such as Point Verdant or other ports of call. | ||
var/list/force_exoplanets = list() | ||
///Exoplanets that this site will prohibit from spawning. Useful for fake planet away sites intended to replace normal exoplanets. | ||
var/list/ban_exoplanets = list() | ||
Comment on lines
+12
to
+15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same thing here about docs |
||
|
||
/datum/map_template/ruin/away_site/New(var/list/paths = null, rename = null) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
document what this list is supposed to contain
(types like
/obj/effect/overmap/visitable/sector/exoplanet/...
)