Exoplanet Forcing & Banning #19373
Open
Exoplanet Forcing & Banning #19373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustingWithYou
requested review from
NonQueueingMatt and
DreamySkrell
as code owners
|
!review |
github-actions
bot
added
the
🗺️ Mapping - Away Ship/Away Site
DreamySkrell
reviewed
Jun 6, 2024
Comment on lines
+15
to
+16
| ///Banned exoplanets. These will be removed from the possible exoplanets list. | ||
| var/list/banned_exoplanets = list() |
There was a problem hiding this comment.
document what this list is supposed to contain
(types like /obj/effect/overmap/visitable/sector/exoplanet/...)
DreamySkrell
reviewed
Jun 6, 2024
Comment on lines
+86
to
+89
| ///For mutually exclusive exoplanet types | ||
| var/list/banned_exoplanets = list() | ||
| ///For guaranteed exoplanet types | ||
| var/list/guaranteed_exoplanets = list() |
There was a problem hiding this comment.
same thing here, and also put it near the ruin_type_whitelist for better organization
DreamySkrell
reviewed
Jun 6, 2024
Comment on lines
+12
to
+15
| ///Exoplanets that this site will force to spawn. Useful for on-planet away sites such as Point Verdant or other ports of call. | ||
| var/list/force_exoplanets = list() | ||
| ///Exoplanets that this site will prohibit from spawning. Useful for fake planet away sites intended to replace normal exoplanets. | ||
| var/list/ban_exoplanets = list() |
There was a problem hiding this comment.
same thing here about docs
NonQueueingMatt
added
the
Changes Required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exoplanets can now force or prevent other exoplanets from spawning. Currently this is only used for Moghes and Ouerea.
Away sites can now force or prevent exoplanets from spawning. Currently unused