-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exoplanet Forcing & Banning #19373
base: master
Are you sure you want to change the base?
Exoplanet Forcing & Banning #19373
Conversation
!review |
///Banned exoplanets. These will be removed from the possible exoplanets list. | ||
var/list/banned_exoplanets = list() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
document what this list is supposed to contain
(types like /obj/effect/overmap/visitable/sector/exoplanet/...
)
///For mutually exclusive exoplanet types | ||
var/list/banned_exoplanets = list() | ||
///For guaranteed exoplanet types | ||
var/list/guaranteed_exoplanets = list() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same thing here, and also put it near the ruin_type_whitelist
for better organization
///Exoplanets that this site will force to spawn. Useful for on-planet away sites such as Point Verdant or other ports of call. | ||
var/list/force_exoplanets = list() | ||
///Exoplanets that this site will prohibit from spawning. Useful for fake planet away sites intended to replace normal exoplanets. | ||
var/list/ban_exoplanets = list() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same thing here about docs
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Exoplanets can now force or prevent other exoplanets from spawning. Currently this is only used for Moghes and Ouerea.
Away sites can now force or prevent exoplanets from spawning. Currently unused