Add HtmlRenderer.Test project, port applicable tests from PeachPDF - #262
Open
jhaygood86 wants to merge 3 commits into
Open
Add HtmlRenderer.Test project, port applicable tests from PeachPDF#262jhaygood86 wants to merge 3 commits into
jhaygood86 wants to merge 3 commits into
Conversation
PeachPDF forked from HTML-Renderer and has since built out a much
larger CSS engine, SVG support, and PDF pipeline, with a large xUnit
test suite covering it. This adds a new HtmlRenderer.Test project
(MSTest, matching this repo's existing test style) and ports the
subset of PeachPDF.Tests that HTML-Renderer's current feature set can
actually exercise, routing tests to the appropriate project:
- HtmlRenderer.Test: CSS parsing/property and Core Dom/Utils unit
tests, using a new lightweight mock RAdapter/RGraphics test harness
(no dependency on any UI framework).
- HtmlRenderer.IntegrationTest: end-to-end layout/paint behavior
tests, using a similar harness backed by the real WinForms adapter.
- HtmlRenderer.PdfSharp.Test: PDF-generation and PdfSharp-adapter
tests.
Of the ~483 candidate test files, the large majority test PeachPDF
features HTML-Renderer doesn't have at all (its own CSS engine, SVG,
flexbox/grid, shadows/gradients, WOFF fonts, bidi text shaping, etc.)
and were left out. Where a ported test exercises a feature that does
exist in HTML-Renderer but whose current implementation isn't spec
compliant, the test is still ported (full assertions intact, so it
documents the real target behavior) but marked
[Ignore("not yet spec compliant")] rather than dropped or forced to
pass.
InternalsVisibleTo grants were added to HtmlRenderer/HtmlRenderer.WinForms/
HtmlRenderer.PdfSharp for their respective test projects, matching the
same grants PeachPDF's own csproj already declares for PeachPDF.Tests.
More tests will be ported incrementally from PeachPDF as HTML-Renderer
backports more of its standard/spec support.
dotnet test's underlying MSBuild VSTest target only accepts a single project (MSB1008: Only one project can be specified), unlike dotnet build. The non-Windows test step passed the *.Test.csproj glob straight to dotnet test, which happened to work when only one project matched it, but now that HtmlRenderer.Test.csproj also matches, dotnet expands the glob to two paths and the step fails outright. Iterate and test each matching project individually instead.
eXpl0it3r
force-pushed
the
port-peachpdf-tests
branch
from
August 21, 2026 19:31
0571cb4 to
69f5ef0
Compare
Collaborator
|
Rebased onto master and removed Claude co-author attribution |
Between opening this PR and now, HTML-Renderer's old hand-rolled CSS parser/CssData was replaced by a real ExCSS-derived engine, and RAdapter/RGraphicsPath/PdfGenerator gained new signatures (multi-stop gradients, @font-face loading, elliptical ArcTo radii, async PDF generation). Rebasing this branch onto that work left several ported test files referencing now-removed APIs (CssParser.ParseCssBlock, CssData.GetCssBlock/ContainsCssBlock, CssParser.ParseBorder, the proprietary corner-radius/ActualCornerNw mechanism). - MockAdapter/RecordingGraphics (both HtmlRenderer.Test and HtmlRenderer.IntegrationTest): implement the new CreateLinearGradientBrush(RPoint, RPoint, stops[]) and LoadFontFaceFontInt overloads, and the 5-arg ArcTo signature. - PdfGeneratorTests: await the now-async PdfGenerator.GeneratePdf. - The 7 CSS unit tests that parsed raw property strings directly now go through CssParser.ParseInlineStyle/IStyleRule for declaration-level checks, or the full LayoutHarness pipeline for cascade-level checks, matching how the rest of this port already verifies behavior. - BorderRadiusIntegrationTests: rewritten against the new engine's real, spec-compliant border-radius properties (ActualBorderTopLeftRadiusX/Y etc.), replacing the now-removed proprietary corner-radius workaround this test previously had to use. Since the real engine fixes several of the compliance gaps the original port had to mark [Ignore("not yet spec compliant")] for, those tests are un-ignored here (cascade specificity, media-query not/only/comma-lists, several illegal-value rejections, all of border-radius). One new regression the port surfaced (a NullReferenceException in the new CSS-Nesting parser on malformed split <style> content) is newly marked [Ignore] with the verified root cause, rather than fixed here or silently dropped.
jhaygood86
force-pushed
the
port-peachpdf-tests
branch
from
August 22, 2026 16:33
24d0280 to
bf2de64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HtmlRenderer.Testproject (MSTest, matching this repo's existingHtmlRenderer.IntegrationTest/HtmlRenderer.PdfSharp.Teststyle) for pure unit tests against the core library, backed by a new lightweight mockRAdapter/RGraphicstest harness with no dependency on any UI framework.HtmlRenderer.Test— CSS parsing/property and Core Dom/Utils unit testsHtmlRenderer.IntegrationTest— end-to-end layout/paint behavior tests, using a similar harness backed by the real WinForms adapterHtmlRenderer.PdfSharp.Test— PDF-generation and PdfSharp-adapter testsmargin: 0 autonever centers,vertical-alignkeywords beyondsub/superare no-ops, mixed-sign margin collapsing is wrong), the test is still ported with its full original assertions intact — so it documents the real target behavior — but marked[Ignore("not yet spec compliant")]rather than dropped or forced to pass.InternalsVisibleTogrants fromHtmlRenderer/HtmlRenderer.WinForms/HtmlRenderer.PdfSharpto their respective new/existing test projects, matching the same grants PeachPDF's own.csprojalready declares forPeachPDF.Tests.More tests will be ported incrementally from PeachPDF as HTML-Renderer backports more of its standard/spec support — this PR is a starting point, not a one-time snapshot.
Test plan
dotnet build Source/HtmlRenderer.sln(Debug and Release) — clean, 0 errorsdotnet testper project:HtmlRenderer.Test: 220 passed, 0 failed, 41 skipped (ignored, spec-compliance gaps)HtmlRenderer.IntegrationTest(new tests): 111 passed, 0 failed, 85 skippedHtmlRenderer.PdfSharp.Test: 15 passed, 0 failedHtmlRenderer.Testproject is already picked up by the existing CI matrix inbuild.ymlwithout changes — it targets plainnet8.0(no UI framework dependency), and its filename already matches the non-Windows job'sSource/Test/**/*.Test.csprojglob, while the Windows job runsdotnet testagainst the whole.sln.