Commit bf2de64
committed
Fix ported tests broken by the CSS engine port and adapter API drift
Between opening this PR and now, HTML-Renderer's old hand-rolled CSS
parser/CssData was replaced by a real ExCSS-derived engine, and
RAdapter/RGraphicsPath/PdfGenerator gained new signatures (multi-stop
gradients, @font-face loading, elliptical ArcTo radii, async PDF
generation). Rebasing this branch onto that work left several ported
test files referencing now-removed APIs (CssParser.ParseCssBlock,
CssData.GetCssBlock/ContainsCssBlock, CssParser.ParseBorder, the
proprietary corner-radius/ActualCornerNw mechanism).
- MockAdapter/RecordingGraphics (both HtmlRenderer.Test and
HtmlRenderer.IntegrationTest): implement the new
CreateLinearGradientBrush(RPoint, RPoint, stops[]) and
LoadFontFaceFontInt overloads, and the 5-arg ArcTo signature.
- PdfGeneratorTests: await the now-async PdfGenerator.GeneratePdf.
- The 7 CSS unit tests that parsed raw property strings directly now
go through CssParser.ParseInlineStyle/IStyleRule for
declaration-level checks, or the full LayoutHarness pipeline for
cascade-level checks, matching how the rest of this port already
verifies behavior.
- BorderRadiusIntegrationTests: rewritten against the new engine's
real, spec-compliant border-radius properties
(ActualBorderTopLeftRadiusX/Y etc.), replacing the now-removed
proprietary corner-radius workaround this test previously had to use.
Since the real engine fixes several of the compliance gaps the
original port had to mark [Ignore("not yet spec compliant")] for,
those tests are un-ignored here (cascade specificity, media-query
not/only/comma-lists, several illegal-value rejections, all of
border-radius). One new regression the port surfaced (a NullReferenceException
in the new CSS-Nesting parser on malformed split <style> content) is
newly marked [Ignore] with the verified root cause, rather than fixed
here or silently dropped.1 parent 69f5ef0 commit bf2de64
20 files changed
Lines changed: 749 additions & 772 deletions
File tree
- Source/Test
- HtmlRenderer.IntegrationTest
- BoxModel
- Painting
- TestSupport
- Text
- HtmlRenderer.PdfSharp.Test
- HtmlRenderer.Test
- Css
- TestSupport
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
116 | 123 | | |
117 | 124 | | |
118 | 125 | | |
119 | 126 | | |
120 | 127 | | |
121 | 128 | | |
122 | 129 | | |
123 | | - | |
| 130 | + | |
124 | 131 | | |
125 | 132 | | |
Lines changed: 116 additions & 96 deletions
Large diffs are not rendered by default.
Lines changed: 23 additions & 22 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
36 | 38 | | |
37 | 39 | | |
38 | 40 | | |
| |||
215 | 217 | | |
216 | 218 | | |
217 | 219 | | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
225 | 227 | | |
226 | | - | |
| 228 | + | |
227 | 229 | | |
228 | 230 | | |
229 | 231 | | |
| |||
263 | 265 | | |
264 | 266 | | |
265 | 267 | | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | 268 | | |
270 | 269 | | |
271 | 270 | | |
272 | 271 | | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | | - | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
277 | 278 | | |
278 | 279 | | |
279 | 280 | | |
| |||
Lines changed: 14 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
33 | 35 | | |
34 | 36 | | |
35 | 37 | | |
| |||
43 | 45 | | |
44 | 46 | | |
45 | 47 | | |
46 | | - | |
| 48 | + | |
47 | 49 | | |
48 | 50 | | |
49 | 51 | | |
| |||
63 | 65 | | |
64 | 66 | | |
65 | 67 | | |
66 | | - | |
| 68 | + | |
67 | 69 | | |
68 | 70 | | |
69 | 71 | | |
| |||
82 | 84 | | |
83 | 85 | | |
84 | 86 | | |
85 | | - | |
| 87 | + | |
86 | 88 | | |
87 | 89 | | |
88 | 90 | | |
| |||
120 | 122 | | |
121 | 123 | | |
122 | 124 | | |
123 | | - | |
| 125 | + | |
124 | 126 | | |
125 | 127 | | |
126 | | - | |
127 | | - | |
128 | | - | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
129 | 131 | | |
130 | 132 | | |
131 | 133 | | |
| |||
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| 36 | + | |
| 37 | + | |
35 | 38 | | |
36 | 39 | | |
37 | 40 | | |
| |||
67 | 70 | | |
68 | 71 | | |
69 | 72 | | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
0 commit comments