Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add twist-stamper node so nav2 example works with humble #28

Conversation

srmainwaring
Copy link
Collaborator

The main addition is to add a twist-stamper node to allow the nav2 example to work with ROS 2 Humble.

See #11 (comment) for details.

Other changes include:

  • Update robot base footprint radius.
  • Ensure the SDF_PATH env variable is set in launch file to allow robot state publisher to resolve the model (and so TF).
  • Display robot model and odometry in rviz.

Dependences

@srmainwaring srmainwaring force-pushed the prs/pr-ros2-navigation-with-twist-stamper branch from 4c2b756 to 1fb59d0 Compare July 22, 2024 07:58
@srmainwaring srmainwaring force-pushed the prs/pr-ros2-navigation-with-twist-stamper branch from 1fb59d0 to ef5357e Compare July 22, 2024 08:06
@Jagadeesh-pradhani
Copy link

Jagadeesh-pradhani commented Oct 11, 2024

Every thing works fine,
Just one thing that, twist_stamped node wasn't working when i ran it with navigation.
Later running it separately worked for me.

Copy link
Collaborator

@Ryanf55 Ryanf55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The twist stamper is working as intended. Excellent work.

@srmainwaring
Copy link
Collaborator Author

srmainwaring commented Oct 29, 2024

Thanks @ryan, I'll merge once the issue with the failing test is resolved.

Ah, that's an upstream issue with ardupilot_gazebo - missing the gstreamer deps in the cmake. Let me get onto that.

@srmainwaring srmainwaring merged commit 9ae6bad into ArduPilot:humble Oct 30, 2024
2 checks passed
@srmainwaring srmainwaring deleted the prs/pr-ros2-navigation-with-twist-stamper branch October 30, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants