Repository navigation
Update x500 - #2359
Merged
Merged
Update x500#2359
Conversation
Signed-off-by: Dr.-Ing. Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
Signed-off-by: Dr.-Ing. Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The changed warning text lacks corresponding POT and PO updates, causing the entire warning to fall back to English in all five supported non-English locales.
1 open issue
What changed in this PR
Updates the Holybro X500 vehicle template and clarifies the parameter editor’s guidance for overriding enforced values.
Changes:
- Adds calibration values for RC channels 11–16 and reorders existing mappings and options.
- Updates IMU batch-logging settings in the tune-evaluation step.
- Changes the warning to direct users to the manual override checkbox.
| File | Description |
|---|---|
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/37_evaluate_the_aircraft_tune_ff_disable.param |
Updates batch-logging count and options. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/06_remote_controller_controller.param |
Adds RC calibration values and reorders existing settings. |
ardupilot_methodic_configurator/frontend_tkinter_parameter_editor_table.py |
Revises the enforced-value warning’s override guidance. |
Review effort: Balanced
| "This parameter already has the correct value for this configuration step.\n" | ||
| "You must not change it, as this would defeat the purpose of this configuration step.\n\n" | ||
| "Add it to other configuration step and change it there if you have a good reason to." | ||
| "Tick the manual override checkbox to the right if you have a good reason to override it." |
Contributor
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update x500
Improve warning message
Checklist
git commit --signoff)Testing
Describe how you tested these changes: