add number 9 (nine) #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe a critical number (9) is missing from the list. Some might argue that it is optional as long as we have 3 in the list but I don't agree. [This link](https://www.quora.com/What-is-special-about-number-nine) has additional convincing arguments on why 9 (nine) is special.
|
Thank you for this @toppare! I can see you have put a great deal of effort into this feature, and you make a compelling case for its inclusion. @neilpate also attempted something similar in this pull request #17 but his implementation had some conflicts which prevented me from reviewing it and it hasn't received any attention for a couple of weeks. As such, I'd be happy to merge this one instead. Thanks again for all your effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe a critical number (9) is missing from the list. Some might argue that it is optional as long as we have 3 in the list but I don't agree. This link has additional convincing arguments on why 9 (nine) is special.