Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the final single digit number #17

Closed
wants to merge 1 commit into from
Closed

Added the final single digit number #17

wants to merge 1 commit into from

Conversation

neilpate
Copy link
Contributor

No description provided.

@AndrewFeeney
Copy link
Owner

Thanks for this contribution. It looks promising, unfortunately this PR has conflicts which makes it difficult for me to review properly. Could you resolve the conflicts and then I'll take another look?

@AndrewFeeney AndrewFeeney mentioned this pull request Mar 2, 2023
Merged
@AndrewFeeney
Copy link
Owner

Thanks again for this @neilpate. I hope you will not take this personally, but I have made the decision to merge #19 in favour of this PR even though this one was first because it achieves what I believe you were going for but also has no conflicts.

This is not intended as an indictment against your development skills. This decision has been made solely for the benefit of the project and the many people who depend on it. If you feel this PR could be modified to expand on the work done by @toppare, please feel free to modify it and reopen it.

Once again thank you, and we hope you will be able to contribute in another way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilpate @AndrewFeeney