Feature/338 limit allowed chars in username or do not use username in code #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robot Results
Passed Tests
|
There was a problem hiding this comment.
De regex is goed (verified met https://www.phpliveregex.com/#tab-preg-replace).
$studentName wordt nu veranderd. Naast hostname, wordt deze ook in de manifest, tlsSecret en manifest filename verwerkt. Was dit de bedoeling? Ik kan gevolgen hiervan nl. niet overzien.
|
Dit zijn allemaal namen voor verschillende resources, welke de student naam als onderdeel hebben van die naam. Dat deze ook opgeschoond worden is goed en gewild. Zo voorkomen we weer andere bugs met de namen van de resources. |
KlaasDijkstraOrdina
approved these changes
Dec 19, 2023
FranSlot
deleted the
feature/338-limit-allowed-chars-in-username-or-do-not-use-username-in-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #338.