Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit allowed chars in username or do not use username in code #338

Closed
KlaasDijkstraOrdina opened this issue Dec 14, 2023 · 1 comment · Fixed by #343
Closed

Limit allowed chars in username or do not use username in code #338

KlaasDijkstraOrdina opened this issue Dec 14, 2023 · 1 comment · Fixed by #343
Assignees
Labels
bug: low prio RAP4 the RAP deployment of november 2020

Comments

@KlaasDijkstraOrdina
Copy link
Contributor

KlaasDijkstraOrdina commented Dec 14, 2023

De situatie

I used [email protected] as username and got an error when generating the Prototype.

Wat er gebeurde er en wat had je verwacht?

Error on Prototype generatie (uses username in domainname, i guess)
Deployment.apps "[email protected]" is invalid: [metadata.name: Invalid value: "[email protected]": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is 'a-z0-9?(.a-z0-9?)*'), metadata.labels: Invalid value: "[email protected]": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.'...

If you solve by choosing not to use the username you might generate a random string instead, but I would advise to solve by limiting allowed chars to domain name RFC + Check code for possible more uses of the username (other limitations).

Screenshot / Video

Context / Source van ampersand script

@KlaasDijkstraOrdina KlaasDijkstraOrdina added bug: low prio RAP4 the RAP deployment of november 2020 labels Dec 14, 2023
@hanjoosten hanjoosten assigned hanjoosten and FranSlot and unassigned hanjoosten Dec 14, 2023
@hanjoosten
Copy link
Member

Hi @FranSlot , This is a similar bug as the one last week. There should be a mapping from the name to the subdomain. For instance, apply a function that removes all characters that are not allowed, or (even better?) substitute them with an allowed character.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: low prio RAP4 the RAP deployment of november 2020
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants