Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved Broken URL in Code of Conduct Link #52

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

mudasirmurtaza
Copy link
Contributor

@mudasirmurtaza mudasirmurtaza commented Oct 3, 2024

This pull request addresses a broken URL in the README file issue #43 that linked to the code of conduct. The incorrect URL has been replaced with the correct one, ensuring that users can now easily access the code of conduct by clicking on the corresponding link.

Changes:

Corrected URL: The URL for the code of conduct has been updated to point to the correct location.
Tested Functionality: The corrected link has been verified to function as expected, taking users directly to the code of conduct page.

Benefits:

  1. Improved user experience by providing a functional link to the code of conduct.
  2. Ensured adherence to project guidelines and standards.
  3. Corrected a potential issue that could have confused or frustrated users.

Screenshot 2024-10-03 203739

@Amna-Hassan04
Copy link
Owner

@mudasirmurtaza Link the issue you resolved with this so i can merge

@mudasirmurtaza
Copy link
Contributor Author

mudasirmurtaza commented Oct 3, 2024

Pull Request Link: link to my PR

Issue Number: Issue no 43

Also please do add the tags of gssoc, hacktoberfest and hacktoberfest accepted.

@Amna-Hassan04
Copy link
Owner

Amna-Hassan04 commented Oct 5, 2024

@mudasirmurtaza you dont just have to mention the issue number, you have to link the issue to this pr so that when i merge this pr the issue closes automatically.

@Amna-Hassan04 Amna-Hassan04 linked an issue Oct 5, 2024 that may be closed by this pull request
@Amna-Hassan04 Amna-Hassan04 self-requested a review October 5, 2024 09:09
Copy link
Owner

@Amna-Hassan04 Amna-Hassan04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the link works now

@Amna-Hassan04 Amna-Hassan04 merged commit 0e61d88 into Amna-Hassan04:main Oct 5, 2024
4 of 5 checks passed
kota2004 pushed a commit to kota2004/Serenity-Guide that referenced this pull request Oct 8, 2024
Resolved Broken URL in Code of Conduct Link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Link to Code of Conduct in README
2 participants