Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24.3 Aarch64 Integration Tests #434

Open
wants to merge 7 commits into
base: customizations/24.3.11
Choose a base branch
from
Open

24.3 Aarch64 Integration Tests #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b6da0a
enable arm integration tests
MyroTk Jul 25, 2024
9032980
Update release_branches.yml
MyroTk Jul 26, 2024
d3b44e6
Build integration images for arm
MyroTk Sep 11, 2024
f7c7373
Update ci.py
MyroTk Sep 11, 2024
60f1681
Force integration arm rebuild
MyroTk Sep 11, 2024
a494831
Update confluent-kafka
MyroTk Sep 11, 2024
3987ff9
Merge branch 'customizations/24.3.11' into 24.3.5_aarch64-integration…
MyroTk Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/release_branches.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,15 @@ jobs:
test_name: Integration tests (release)
runner_type: altinity-on-demand, altinity-type-cpx51, altinity-in-ash, altinity-image-x86-system-ubuntu-22.04
data: ${{ needs.RunConfig.outputs.data }}
IntegrationTestsAarch64:
needs: [RunConfig, BuilderDebAarch64]
if: ${{ !failure() && !cancelled() }}
uses: ./.github/workflows/reusable_test.yml
secrets: inherit
with:
test_name: Integration tests (aarch64)
runner_type: altinity-on-demand, altinity-type-cax41, altinity-image-arm-system-ubuntu-22.04
data: ${{ needs.RunConfig.outputs.data }}
#############################################################################################
##################################### REGRESSION TESTS ######################################
#############################################################################################
Expand Down Expand Up @@ -583,6 +592,7 @@ jobs:
- IntegrationTestsAsan
- IntegrationTestsTsan
- IntegrationTestsRelease
- IntegrationTestsAarch64
- CompatibilityCheckX86
- CompatibilityCheckAarch64
- RegressionTestsRelease
Expand Down
3 changes: 0 additions & 3 deletions docker/images.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"dependent": []
},
"docker/test/integration/base": {
"only_amd64": true,
"name": "altinityinfra/integration-test",
"dependent": []
},
Expand Down Expand Up @@ -65,7 +64,6 @@
"dependent": []
},
"docker/test/integration/runner": {
"only_amd64": true,
"name": "altinityinfra/integration-tests-runner",
"dependent": []
},
Expand All @@ -88,7 +86,6 @@
"dependent": []
},
"docker/test/integration/helper_container": {
"only_amd64": true,
"name": "altinityinfra/integration-helper",
"dependent": []
},
Expand Down
2 changes: 1 addition & 1 deletion docker/test/integration/runner/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ RUN python3 -m pip install --no-cache-dir \
azure-storage-blob~=12.19.0\
boto3~=1.34.24 \
cassandra-driver~=3.28.0\
confluent-kafka~=1.9.2 \
confluent-kafka~=2.3.0 \
delta-spark~=2.3.0 \
dict2xml~=1.7.3 \
dicttoxml~=1.7.16 \
Expand Down
3 changes: 2 additions & 1 deletion tests/ci/ci.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1285,7 +1285,8 @@ def _configure_docker_jobs(docker_digest_or_latest: bool) -> Dict:
# FIXME: we need login as docker manifest inspect goes directly to one of the *.docker.com hosts instead of "registry-mirrors" : ["http://dockerhub-proxy.dockerhub-proxy-zone:5000"]
# find if it's possible to use the setting of /etc/docker/daemon.json (https://github.com/docker/cli/issues/4484#issuecomment-1688095463)
docker_images_helper.docker_login()
missing_multi_dict = check_missing_images_on_dockerhub(imagename_digest_dict)
# missing_multi_dict = check_missing_images_on_dockerhub(imagename_digest_dict) #REMOVEME: force clickhouse to build integration
missing_multi_dict = {'altinityinfra/integration-test' : imagename_digest_dict['altinityinfra/integration-test'], 'altinityinfra/integration-tests-runner':imagename_digest_dict['altinityinfra/integration-tests-runner'], 'altinityinfra/integration-helper':imagename_digest_dict['altinityinfra/integration-helper']}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? do we need to always rebuild those images for whatever reason?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not always, just once. Will be removed before final merge.

Those images were amd only.

missing_multi = list(missing_multi_dict)
missing_amd64 = []
missing_aarch64 = []
Expand Down
Loading