-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24.3 Aarch64 Integration Tests #434
base: customizations/24.3.11
Are you sure you want to change the base?
Conversation
This is an automated comment for commit 3987ff9 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
@@ -1284,7 +1284,8 @@ def _configure_docker_jobs(docker_digest_or_latest: bool) -> Dict: | |||
# FIXME: we need login as docker manifest inspect goes directly to one of the *.docker.com hosts instead of "registry-mirrors" : ["http://dockerhub-proxy.dockerhub-proxy-zone:5000"] | |||
# find if it's possible to use the setting of /etc/docker/daemon.json (https://github.com/docker/cli/issues/4484#issuecomment-1688095463) | |||
docker_images_helper.docker_login() | |||
missing_multi_dict = check_missing_images_on_dockerhub(imagename_digest_dict) | |||
# missing_multi_dict = check_missing_images_on_dockerhub(imagename_digest_dict) #REMOVEME: force clickhouse to build integration | |||
missing_multi_dict = {'altinityinfra/integration-test' : imagename_digest_dict['altinityinfra/integration-test'], 'altinityinfra/integration-tests-runner':imagename_digest_dict['altinityinfra/integration-tests-runner'], 'altinityinfra/integration-helper':imagename_digest_dict['altinityinfra/integration-helper']} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? do we need to always rebuild those images for whatever reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not always, just once. Will be removed before final merge.
Those images were amd only.
7d2ef25
to
32550b4
Compare
32550b4
to
a494831
Compare
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):