Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
eac1293
adds preferences switch to turn off YouTube and show a callout in its…
jeremybmerrill Jul 2, 2020
faa3f02
updates packages; adds Testing sheet
jeremybmerrill Jul 2, 2020
8bfcf8d
Remove birthday
jeremybmerrill Jul 2, 2020
bd618ab
fixes youtube on-off build config switch
jeremybmerrill Jul 2, 2020
e41924d
add notes to README
jeremybmerrill Jul 2, 2020
d0dd043
save build configs
jeremybmerrill Jul 2, 2020
94393a2
jeremy's preferences: commit build configs, stop with this husky thing
jeremybmerrill Jul 2, 2020
81657a3
testing instructions and updates readme for whitelabeling
jeremybmerrill Jul 2, 2020
9e1cf80
we don't need Facebook.com permissions since we use a content script
jeremybmerrill Jul 7, 2020
dbc0daf
remove externally_connectable, which isn't necessary
jeremybmerrill Jul 8, 2020
9dc6724
capitalization fix
jeremybmerrill Jul 14, 2020
5df2eba
Merge branch 'develop' of github.com:AlgorithmicTransparencyInstitute…
jeremybmerrill Jul 17, 2020
6dcc501
no need to re-ask TGAM-upgrade users for consent
jeremybmerrill Jul 20, 2020
1488d6f
fix styles on terms of service, adds thank you
jeremybmerrill Jul 20, 2020
3735870
hotfix for friends-name issue
jeremybmerrill Jul 20, 2020
a06fc49
by default, build youtube
jeremybmerrill Jul 21, 2020
58b312e
remove outer layer of ad just in case for post2020
jeremybmerrill Jul 21, 2020
3ab4acf
danged eslint
jeremybmerrill Jul 21, 2020
74c8701
hotfix for youtube ads when hostVideo is unset
jeremybmerrill Jul 21, 2020
8be94db
set version for eventual launch
jeremybmerrill Jul 21, 2020
0beda5e
change versions for eventual launch
jeremybmerrill Jul 21, 2020
40546e4
re-adds prefs for country/age/gender
jeremybmerrill Jul 21, 2020
c0e2714
v2.0.1, v3.0.1 for fixing prefs for country/age/gender
jeremybmerrill Jul 21, 2020
41cd184
adds explanatory note for legacy users
jeremybmerrill Jul 23, 2020
1ead293
YT placeholder text change
jeremybmerrill Jul 23, 2020
1f6e58b
vx.0.2 -- puzzle piece logo and legacy text fixes
jeremybmerrill Jul 23, 2020
0f373c1
remove geckoId for legacy version (since Moz store complained)
jeremybmerrill Jul 24, 2020
bb792bd
Detect political ads from post2020, which are buttons not links
jeremybmerrill Aug 27, 2020
19b6643
Filters out posts that don't have platformItemId and adTargetingData.
mallochine Aug 29, 2020
4768b63
remove all debug code from commit that adds filter on ads that have m…
mallochine Aug 30, 2020
eeef17e
Rename applyFilters to applyAdInfo since `applyFilters(posts)` implies
mallochine Aug 30, 2020
b0a14d3
coreDataGrab shouldn't analyze elements' siblings
jeremybmerrill Aug 31, 2020
76a6198
package lock updated
jeremybmerrill Aug 31, 2020
a776def
updates instructions for local development
jeremybmerrill Aug 31, 2020
ef4d379
v*.0.4
jeremybmerrill Aug 31, 2020
da63183
comment clarification
jeremybmerrill Aug 31, 2020
f6854ed
extension can be built outside a git repo; shortSha will return 'oneo…
jeremybmerrill Sep 2, 2020
5069d93
vx.0.5
jeremybmerrill Sep 2, 2020
b822eeb
adjust release ritual steps
jeremybmerrill Sep 2, 2020
d252f78
Issue: Archive has poor display issues for post2020 ads.
mallochine Sep 6, 2020
f000d0a
add parser for CTA Link
mallochine Sep 7, 2020
cbc86bc
fix pretty problem
mallochine Sep 7, 2020
27a8f0b
FacebookRenderer: distinguish ad copy text that appears before and after
mallochine Sep 12, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,3 @@
/node_modules/
.idea/
/coverage/

# ignore alternative build configs
*-build-config.js
31 changes: 29 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ Once installed **you must accept the standard terms and conditions of use**. The

### Installation

There is currently an issue with one or more of the dependencies which means that to install you **must** use
There is currently an issue with one or more of the dependencies which means that to install you **must** run `npm install` and then

```sh
npm ci
```

instead of `npm install`.
instead of just `npm install`.

## Continuous build environment (single machine)

Expand All @@ -49,6 +49,17 @@ Build the extension continuously as you edit files:
npm run watch
```

### Actual real-life development:

in two separate terminals, run these commands.

```sh
npm run chrome -- -- --env.file=./nyu-build-config.js --env.build=debug --env.config=std
npm run watch -- --env.file=./nyu-build-config.js --env.browser=chrome --env.build=debug --env.config=std
```

This starts a fresh Chrome install and also continuously monitors the code and recompiles it.

### Build output

Both of the above scripts will generate eight output folders named in the format `{browser}-{config}-{build}`.
Expand Down Expand Up @@ -92,6 +103,22 @@ So if, for example, you create your own build config called `alt-build-config.js

Any API URL you set in that file will be used as the default url, unless you specify an `--env.api` option. The `--env.api` option will override whatever you set in your copy of `build-config.js`.

## NYU Release Ritual

1. up the version in the build config file (`nyu-build-config.js` or `legacy-build-config.js`). Legacy is `v2.x.y`, Full is `v3.x.y`.
2. tag a version, push tag, `git tag v3.0.2` (or whatever).
3. build both legacy and standard
- legacy:
1. `npm run build -- --env.file=./legacy-build-config.js --env.build=release --env.config=std`
2. `pushd build/chrome-std-release && zip -r0 ../chrome-$(jq .version manifest.json | tr -d \").zip ./* && popd`
3. `pushd build/firefox-std-release && zip -r0 ../firefox-$(jq .version manifest.json | tr -d \").zip ./* && popd`
- standard:
1. `npm run build -- --env.file=./nyu-build-config.js --env.build=release --env.config=std`
2. `pushd build/chrome-std-release && zip -r0 ../chrome-$(jq .version manifest.json | tr -d \").zip ./* && popd`
3. `pushd build/firefox-std-release && zip -r0 ../firefox-$(jq .version manifest.json | tr -d \").zip ./* && popd`
4. download source zip for Firefox
5. upload source zip to Firefox with msg "There are instructions for how to build the extension in the README in the extension/ folder in the archive -- you'll want to run `npm install`, then `npm ci` and then use `$ npm run build -- --env.file=./nyu-build-config.js --env.build=release --env.config=std --env.browser=firefox` to generate the same minified, production code as in the uploaded version of the extension. Be sure to check the output for sporadic network errors; I've verified that these instructions work in a clean build environment."

## Unit tests

Unit tests do not require a running backend server.
Expand Down
25 changes: 25 additions & 0 deletions TESTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
in Legacy version:

1. Share Sponsored Posts ON Share Ad Targeting Information ON

ensure that ads and targeting is sent ensure that public posts are NOT sent

CHECK

2. Share Sponsored Posts ON Share Ad Targeting Information OFF

ensure that targeting is not sent, but ads are

CHECK

3. Share Sponsored Posts OFF Share Ad Targeting Information ON

ensure that nothing is sent.

CHECK

in both versions:

Share My Language

CHECK
274 changes: 147 additions & 127 deletions build-config.js

Large diffs are not rendered by default.

250 changes: 250 additions & 0 deletions legacy-build-config.js

Large diffs are not rendered by default.

265 changes: 265 additions & 0 deletions nyu-build-config.js

Large diffs are not rendered by default.

Loading