Feature/post2020 archive display #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… place on the prefs page
…/social-media-collector into fork/nyulegacy
I chose to filter them out in sendPosts as sendPosts was already filtering for posts that were already in the archive. The other place you might think to put the filter was in `applyFilters` as invoked in `feedScanner.js`. However, this place is not correct, because `applyFilters` doesn't mean what you think it does. It does not mean "applying filters". It actually means "apply info on posts that pass this filter". What kind of "info"? Something like applyAdTargetingInfo and applyAdId (going off the top of my head). So...applyFilters wasn't actually doing any filtering at all. Very confusing. It should be renamed.
the number of posts will be shortened by some filter, when that is not true at all. The actual behavior is that ad info is applied to the posts. The only 'filtering' going on is that the ad info is only applied to certain posts, not all posts. An example of a filter is "canShareSponsored". If not true, the ad info is not applied. (this last bit is off the top of my head)
coreDataGrab exists to find the ad ID and token pertaining to an element by recursively iterating through its keys -- and those of any elements/arrays/objects that are values -- to find anything that seems like an ad ID or client token. Previously, this would analyze the `return` key which is something like the parent element. This meant that it would traverse up the tree and back down to siblings, which led to mistakes.
…ff' if .git is absent
Fix: a custom parser to extract the ad copy and images. Then write our own html to display the contents.
the image. Currently it's broken in that the pre and post image text appear as one paragraph. Now they are properly separated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enhancement to do an ok job of displaying post2020 ads in the archive