Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(agoric-cli): add agoric run; deprecate beta features #904

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

dckc
Copy link
Member

@dckc dckc commented Jan 3, 2024

  • minimal reference doc for agoric run
  • cite discussion of using agoric run with writeCoreProposal

also includes:

  • deprecate stuff related to getting started by cloning agoric-sdk
  • deprecate "beta" stuff; i.e. ag-solo / sim chain stuff

these last 2 changes can be removed if we want to postpone that step.

dckc added 2 commits January 3, 2024 15:50
 - CLI Commands -> CLI Reference
 - prune initial "in this order" section in favor of list from `agoric help`
 - agoric run: brief usage; cite writeCoreProposals discussion
 - init: deprecate in favor of `yarn create @agoric/dapp`
 - Syntax -> Usage
 - markdown lint: `-` rather than `*` for lists; `_` rather than `*`
   for italic
 - install: deprecate
   This is supposed to be able to install from npm.
   I thought `agoric install agoric-upgrade-11wf` was supposed to do it,
   but I got an endless series of questions about what versions to
   use. If we have a form that's tested in ci, I'm not aware of it.
   Until we do, let's deprecate this.
 - start local-chain: document briefly
 - start: deprecate as beta feature
 - deploy: deprecate as beta feature
 - open: deprecate as beta feature
Comment on lines +91 to +93
## ~~agoric install~~

_Deprecated_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agoric install can still be used to change the NPM versions of the sdk packages. Maybe we should rename it "agoric update", but that's an sdk change (which could be combined with a resolutions mechanism for endo). @michaelfig thoughts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agoric install can still be used to change the NPM versions of the sdk packages.

I'm not clear on what that means. Care to sketch a sentence or two of documentation?

We don't have a test for this feature, by chance, do we?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agoric install <npmtag> is definitely tested and used in tests. It updates all the known agoric dependencies to that npm tag. However I think the functionality is currently overloaded, and it's likely acceptable to not advertise it until we have a more complete story, which also handles the issues of version tearing we've noticed with endo packages.

Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this, just want to ensure we don't accidentally remove agoric init while we're still using it as internals for yarn create @agoric/dapp.

## agoric init
## ~~agoric init~~

_Deprecated in favor of [yarn create @agoric/dapp](../getting-started/#creating-your-dapp-from-a-template)_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the right verbiage, but it may be worthwhile to say something like:

Suggested change
_Deprecated in favor of [yarn create @agoric/dapp](../getting-started/#creating-your-dapp-from-a-template)_
_Internal implementation for the preferred [yarn create @agoric/dapp](../getting-started/#creating-your-dapp-from-a-template)_

if we removed agoric init, then the yarn create @agoric/dapp form would stop working.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low priority comment:
I feel like as a dapp developer trying to use agoric docs to learn to write a contract/dapp and how to initialize a project, details of internals aren't important to understand. I'm in favor of deprecated.

Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e33b360
Status: ✅  Deploy successful!
Preview URL: https://8d67d123.documentation-7tp.pages.dev
Branch Preview URL: https://dc-agoric-run.documentation-7tp.pages.dev

View logs

@ivanlei ivanlei added the automerge:merge Mergify: merge to master automerge:merge label Jan 8, 2024
@ivanlei ivanlei merged commit 89addfc into main Jan 8, 2024
4 checks passed
@ivanlei ivanlei deleted the dc-agoric-run branch January 8, 2024 15:26
This was referenced Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:merge Mergify: merge to master automerge:merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants