You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now we are effectively no longer testing that released NPM packages are compatible with dapps if they were to upgrade to these packages. While the current agoric install $npm_tag is undocumented (see Agoric/documentation#904 (comment)) and has limitations (it relies on yarn internally, see #9209), it's still usable to force update deps in dapps.
This is however half the problem, as the dapp uses an a3p based chain, which is by definition older than the agoric-sdk under test, and publishing a contract build from a newer SDK to an older chain is not supported. To make this work correctly, we'd need to use an a3p image built from an upgraded chain, like the one produced by the layers of a3p-integration. As such, this is likely a test that need to run on top of the docker-build test now.
Link-cli would need extra work to get working as it'd need to link against the SDK inside the a3p image (which would not translate well to outside the docker image links, unless we got smart on mount points). We should consider dropping altogether since it's not a flow intended for public usages anymore.
To Reproduce
Steps to reproduce the behavior:
Run getting-started integration test. E.g. locally with:
scripts/registry.sh bg-publish registry/yarn
scripts/registry.sh test registry/yarn main
Expected behavior
dapp in integration test using agoric packages built from the agoric-sdk source
Platform Environment
CI
The text was updated successfully, but these errors were encountered:
Describe the bug
#8829 updated the getting-started test to actually follow the getting started steps from our documentation. However when doing so, it dropped the step where the dapp is updated to use the just created NPM packages from the agoric-sdk repo. This is a side effect of dapp instructions no longer using agoric-cli to install deps.
Now we are effectively no longer testing that released NPM packages are compatible with dapps if they were to upgrade to these packages. While the current
agoric install $npm_tag
is undocumented (see Agoric/documentation#904 (comment)) and has limitations (it relies onyarn
internally, see #9209), it's still usable to force update deps in dapps.This is however half the problem, as the dapp uses an a3p based chain, which is by definition older than the agoric-sdk under test, and publishing a contract build from a newer SDK to an older chain is not supported. To make this work correctly, we'd need to use an a3p image built from an upgraded chain, like the one produced by the layers of
a3p-integration
. As such, this is likely a test that need to run on top of the docker-build test now.Link-cli would need extra work to get working as it'd need to link against the SDK inside the a3p image (which would not translate well to outside the docker image links, unless we got smart on mount points). We should consider dropping altogether since it's not a flow intended for public usages anymore.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
dapp in integration test using agoric packages built from the agoric-sdk source
Platform Environment
The text was updated successfully, but these errors were encountered: