Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need n? #13

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Do we need n? #13

merged 3 commits into from
Jan 25, 2024

Conversation

AdamOrmondroyd
Copy link
Owner

After some deep introspection about whether or not AdaptiveKnotPrior actually needs N_min and N_max, I spotted that AdaptiveKnotPrior.__n_x_nodes doesn't need to be set until __call__

@AdamOrmondroyd AdamOrmondroyd merged commit 208bcc6 into main Jan 25, 2024
5 checks passed
@AdamOrmondroyd AdamOrmondroyd deleted the doweneedn branch January 25, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AdamOrmondroyd