Alts Attributes #862
Closed
Alts Attributes #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #774, we added the ability to use the "reindex" function in location choice models, essentially allowing a user to merge in data from the land_use table into the chooser table from inside a utility spec. This is problematic for sharrow.
This PR takes a different approach: typically the alternatives table in the sampling step as an index-only dataframe, but it doesn't need to be. Here we add a config setting on the trip destination component to allow users to name columns that should be merged onto the alternatives before they are broadcast against the choosers. This is more efficient and works with sharrow.
This PR pairs with ActivitySim/sandag-abm3-example#11, which implements it on the SANDAG demo model.