More efficient merge of land use into choosers on trip destination. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhensle
reviewed
May 2, 2024
There was a problem hiding this comment.
I am not convinced this is the best solution... Can't we instead just create an alts preprocessor for trip destination? This would allow us to just do whatever merging we want with the landuse table, similar to what we did for the vehicle type model in ActivitySim/activitysim#806. Then we can get rid of an additional extension for the sandag model and all of the ALTS_ATTRIBUTES_SAMPLING code (ie ActivitySim/activitysim#862) needed to support this.
I do not expect that this will be the only model where we will want to do merging of this kind either. Having a separate extension that needs to get passed around will make this a hassle in the future.
|
Closed in favor of #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10 (makes trip destination work with Sharrow).
ALTS_ATTRIBUTES_SAMPLINGto trip destination config.land_use_taztable, to add the column we need.This PR also replaces the ".zip" reference pipeline with an unzipped equivalent. We lose the compression of the zip archive, but we get the ability to see and fix small changes in the pipeline without replacing the entire pipeline binary file. For instance, this PR adds a new column to the land_use_taz table, but makes no other changes anywhere else.
This PR requires ActivitySim/activitysim#862