-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RQD] Fix core detection on Windows platforms #1468
[RQD] Fix core detection on Windows platforms #1468
Conversation
9e79b17
to
d8e4190
Compare
d8e4190
to
ddeb921
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor comments. Everything else looks good to me.
Hi @anton-ubi If I'm not mistaken, this is your first contribution. Welcome to the project. Please sign the CLA to get the pipeline unblocked. |
Yes it is. Thank you. I'll look into that. |
Co-authored-by: Kern Attila GERMAIN <[email protected]> Signed-off-by: Diego Tavares <[email protected]>
Signed-off-by: Diego Tavares <[email protected]>
There are still some lint errors to be fixed before we can merge this PR |
@anton-ubi I'm in the process of implementing a proper core detection mechanism for Windows without dependency to WMI. |
eb494e7
into
AcademySoftwareFoundation:master
[celebrate] Anton Brand reacted to your message:
…________________________________
From: Diego Tavares ***@***.***>
Sent: Wednesday, December 4, 2024 7:07:01 PM
To: AcademySoftwareFoundation/OpenCue ***@***.***>
Cc: Anton Brand ***@***.***>; Mention ***@***.***>
Subject: Re: [AcademySoftwareFoundation/OpenCue] [RQD] Fix core detection on Windows platforms (PR #1468)
Merged #1468<#1468> into master.
—
Reply to this email directly, view it on GitHub<#1468 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BDAVROHCNVHCZFVEEOIVYY32D5HFLAVCNFSM6AAAAABMQZ32VWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGUZTCMRTGYYDKNQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Link the Issue(s) this Pull Request is related to.
#1469
Summarize your change.
Fix an error on Windows platforms where a submitted job could not be picked up properly due to available processors incorrect detection.
The
reserveHT
method of the RQDMachine
class relies on a__procs_by_physid_and_coreid
attribute that is not correctly filled when on a Windows platform.See:
reserveHT
relying on__procs_by_physid_and_coreid
: https://github.com/AcademySoftwareFoundation/OpenCue/blob/master/rqd/rqd/rqmachine.py#L842__procs_by_physid_and_coreid
being filled only if on a Linux platform: https://github.com/AcademySoftwareFoundation/OpenCue/blob/master/rqd/rqd/rqmachine.py#L613