add a flag for edge TB so we can unlink it completely #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it looks good thanks |
|
can you mark you changes between the begin and end libafl code markers? like here qemu-libafl-bridge/linux-user/elfload.c Line 3316 in fd6a2f3 |
|
Yes, there are also other modifications that need to be pushed. I will push them soon |
rmalmain
added a commit
that referenced
this pull request
May 1, 2024
* add a flag for edge TB so we can unlink it completely * Call tb_phys_invalidate on edge's TBs. Added libafl code comments * Edge flag is now applied to cflags instead of flags --------- Co-authored-by: Romain Malmain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First coarse attempt at resolving #52. It fixes the bug for me, no more infinite loop.
I added an additional flag when creating a new edge, which is later checked in
tb_jmp_unlinkto verify if we're unlinking an edge. In case, we calltb_reset_edge(this can actually be a recursive call attb_jmp_unlink, but I didn't want to complicate it too much for now) and unlink the edge from its predecessor.@andreafioraldi @rmalmain if you think it makes any sense, I can improve it.