Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix function name in comment #3252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eveneast
Copy link

No description provided.

@eveneast
Copy link
Author

Anything need I to do? If have, Please feel free to tell me.

@Andriamanitra
Copy link
Contributor

@eveneast The spelling change you made is inconsistent with all other doc comments in the same file, such as the ones on hVSplit and vHSplit. Either way of writing it is perfectly readable, there is no reason to change it. unsplit is not even an exported function so minor tweaks to its doc comment are not worth anything to users.

Pull requests like this are not an effective way to contribute to open source. You don't want to be wasting maintainers' time on a single letter change in a comment.

@@ -438,7 +438,7 @@ func (n *Node) VSplit(right bool) uint64 {
return n.hVSplit(0, right)
}

// unsplits the child of a split
// unsplit the child of a split
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// unsplit the child of a split
// unsplit removes child split i and resizes the rest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants