-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve micro's file format hightlight #3199
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Yevhen Babiichuk (DustDFG) <[email protected]>
Also at least the BTW I've updated the colorgroups documentation in PR #3203. Yeah, current approach in
just:
|
I agree with |
I can't see why? |
Wouldn't user want to create custom colors? You can think that all the possible situations are covered and won't new top-level names exist but then someone just wants to create git highlight and then new colorgroup is added. I mean just to highlight any valid by syntax colorgroup |
One more rock in the side of the color groups. They aren't coherent in my opinion. As like for |
Well, perhaps... OTOH then completely unsupported top-level names (e.g. if the user makes a typo) would be highlighted as well. |
Perhaps, but changing them now would mean at least breaking compatibility.
Hmm, is |
Speaking of specifically |
Looks like no. Grep said about |
Honestly I don't think current approach is flexible