-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Danish language support and translation #270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new language package!
Once this is merged i can add the danish wikipedia dictionary if you don't want to generate it yourself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be cleared
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright! I wasn't sure what to do with it. Cleared in the latest commit!
packages/languages/de/README.md
Outdated
@@ -19,7 +19,7 @@ import { ZxcvbnFactory } from '@zxcvbn-ts/core' | |||
import * as zxcvbnCommonPackage from '@zxcvbn-ts/language-common' | |||
import * as zxcvbnDePackage from '@zxcvbn-ts/language-de' | |||
|
|||
const password = 'somePassword' | |||
const password = 'nogleAdgangskode' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong language pack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops my bad. Also fixed in the latest commit!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MrWook. I'd greatly appreciate it if you could add the Wikipedia dictionary.
This should get us started!
In the future, one could consider adding more word lists. Especially that pwned password list looked relevant.