-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arabic Language Package #229
Conversation
Note that I removed the common words list because it's very rare to use Arabic words (with Arabic characters) in passwords, I do think that if someone uses Arabic characters in their password it could make it more secure than a regular password with Latin characters (I know there are different factors to determine, but I think it makes the password less predictable) |
Hey thank you for your contribution! The name lists seems like the japanese name list where the characters are switched with roman letters. |
This is true, people often write their name in its English transliteration. This is why I included Arabic names list in Latin letters.
Yes! This is a great idea because unfortunately I didn't find ready lists of most popular Arabic names / words in their English form, the source I found for last names and first names didn't contain that many names (I added some myself) and didn't have female names either.
Edit: regarding the most common words, to be honest I'm not sure if people might use transliterated Arabic words in passwords, but even if some do, we'll also have to consider different spellings of words, and some people might use numbers instead of some letters like '7abibi' instead of 'Habibi' for example (Arabic chat alphabet) |
@itsmohmans i investigate a little bit into the arabic language and it seems like there isn't really a suitable way of converting it to roman letters. As you already said there are to many different ways of converting it and the tools that are doing it only do it for exactly one kind of way. So lets stick with this MR and maybe in the future we will have an idea about it |
No description provided.