Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arabic Language Package #229

Merged
merged 5 commits into from
Sep 17, 2023

Conversation

itsmohmans
Copy link
Contributor

No description provided.

@itsmohmans
Copy link
Contributor Author

Note that I removed the common words list because it's very rare to use Arabic words (with Arabic characters) in passwords, I do think that if someone uses Arabic characters in their password it could make it more secure than a regular password with Latin characters (I know there are different factors to determine, but I think it makes the password less predictable)

@MrWook MrWook added the enhancement New feature or request label Sep 1, 2023
@MrWook
Copy link
Collaborator

MrWook commented Sep 6, 2023

Hey thank you for your contribution!

The name lists seems like the japanese name list where the characters are switched with roman letters.
Wouldn't this also apply to the arabic language usage with password. I would assume that like in japanese people would write common arabic words in roman letters instead of arabic letters 🤔
This would mean that it would be the best if we have some kind of "arabic -> roman" letter parser and parse the common words list and the wikipedia entries with it.

@itsmohmans
Copy link
Contributor Author

itsmohmans commented Sep 6, 2023

I would assume that like in japanese people would write common arabic words in roman letters instead of arabic letters

This is true, people often write their name in its English transliteration. This is why I included Arabic names list in Latin letters.

This would mean that it would be the best if we have some kind of "arabic -> roman" letter parser and parse the common words list and the wikipedia entries with it.

Yes! This is a great idea because unfortunately I didn't find ready lists of most popular Arabic names / words in their English form, the source I found for last names and first names didn't contain that many names (I added some myself) and didn't have female names either.
Aggregating names translations from Wikipedia is a good idea, but we might run into 2 problems

  1. I think ًwikipedia tends to translate the name rather than transliterates it. An example of the name "يعقوب" which Arabs often transliterate it to "Yacoub" or "Yaqoub", but its English Wikipedia page shows the name in its translated English version which is "Jacob".
  2. Many Arabic names can have different spellings in their English transliteration, take Mohamed as an example, some people write it as Mohammad or Mohammed or Muhammad. If we add a script that aggregate names, I don't know how we can handle cases of different spellings of the same name.

Edit: regarding the most common words, to be honest I'm not sure if people might use transliterated Arabic words in passwords, but even if some do, we'll also have to consider different spellings of words, and some people might use numbers instead of some letters like '7abibi' instead of 'Habibi' for example (Arabic chat alphabet)

@MrWook
Copy link
Collaborator

MrWook commented Sep 17, 2023

@itsmohmans i investigate a little bit into the arabic language and it seems like there isn't really a suitable way of converting it to roman letters. As you already said there are to many different ways of converting it and the tools that are doing it only do it for exactly one kind of way. So lets stick with this MR and maybe in the future we will have an idea about it

@MrWook MrWook merged commit 04c4a1f into zxcvbn-ts:master Sep 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants