Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test case && issue of exceeding selectors #74

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

khiav223577
Copy link

@khiav223577 khiav223577 commented Nov 7, 2016

Hi, I'm trying to fix #72 (comment) and #71
I modify some test cases for the 1st issue and add a regression test case for the 2nd.
I try hard to make sure this PR pass all the tests, but have trouble with some of them ( #72 (comment) ). Could you help me?

@jhilden
Copy link
Contributor

jhilden commented Nov 28, 2016

Hi reoy, thanks for your PR. I meant to take a look at it, but didn't find the time.

Maybe it makes sense to ping the author(s) of the code you changed to answer your questions?

Concerning the issue with the tests, can you maybe elaborate what the issue is and what you already tried? I think that could increase the change of somebody being able to help.

@khiav223577
Copy link
Author

khiav223577 commented Dec 1, 2016

What I want to change mainly is this line: https://github.com/zweilove/css_splitter/pull/74/files#diff-3b8e9eb6bd155a54d793812eccd2b02cL15
because it splits the rules wrongly, for example:

"@media (min-width 768px){.a{}}".scan(/[^}]*}/).to_a 
# => ["@media (min-width 768px){.a{}", "}"] `

The author of the code is you. (6be6a2b#diff-3b8e9eb6bd155a54d793812eccd2b02cR15)
Maybe you can explain this line for me when you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about test case
2 participants