Track data for channel folders! #1894
Conversation
chrisbobbe
force-pushed
the
pr-channel-folders
branch
from
fc0b7d9 to
84604e0
Compare
|
(Fixed |
rajveermalviya
added
integration review
lib/api/model/initial_snapshot.dart
Outdated
| final UnreadMessagesSnapshot unreadMsgs; | ||
|
|
||
| final List<ChannelFolder>? channelFolders; |
There was a problem hiding this comment.
nit: docs have these in opposite order
lib/api/model/initial_snapshot.dart
Outdated
|
|
||
| final UnreadMessagesSnapshot unreadMsgs; | ||
|
|
||
| final List<ChannelFolder>? channelFolders; |
lib/api/model/initial_snapshot.dart
Outdated
|
|
||
| final UnreadMessagesSnapshot unreadMsgs; | ||
|
|
||
| final List<ChannelFolder>? channelFolders; |
There was a problem hiding this comment.
nit: commit-message prefixes, similar to #1869 (comment) ; the current revision has
63b5b83 initial_snapshot: Add channelFolders
36e7c96 model: Add ZulipStream.folderId
3da70bc api: Add channel_folder event
3ff64be store: Add channelFolders
84604e0 channel: Add ChannelStore.compareChannelFolders
and I think the first three should all say "api:".
lib/api/model/model.dart
Outdated
| // TODO(server-11) delete TODO but keep optional, for channels not in folders | ||
| int? folderId; |
There was a problem hiding this comment.
This is equivalent to not having a TODO, right? That seems simpler 🙂
| ChannelPostPolicy? channelPostPolicy; // TODO(server-10) remove | ||
| // TODO(server-11) delete TODO but keep optional, for channels not in folders | ||
| int? folderId; | ||
| // final bool isAnnouncementOnly; // deprecated for `channelPostPolicy`; ignore |
There was a problem hiding this comment.
nit: this stanza is all various kinds of permission settings; let's pull this field out separately, earlier.
(We already have this class's fields in a different order from the docs in order to be more logical, in particular grouping description with renderedDescription.)
| channelFolders[newChannelFolder.id] = newChannelFolder; | ||
| case ChannelFolderUpdateEvent(): |
There was a problem hiding this comment.
nit: bit easier to read if each case is its own new stanza (since they're each nontrivial):
| channelFolders[newChannelFolder.id] = newChannelFolder; | |
| case ChannelFolderUpdateEvent(): | |
| channelFolders[newChannelFolder.id] = newChannelFolder; | |
| case ChannelFolderUpdateEvent(): |
lib/model/channel.dart
Outdated
| final orderA = a.order; | ||
| final orderB = b.order; | ||
| return switch ((orderA, orderB)) { |
There was a problem hiding this comment.
nit: since the switch already means these are consumed just once, can inline them for I think a bit more clarity:
| final orderA = a.order; | |
| final orderB = b.order; | |
| return switch ((orderA, orderB)) { | |
| return switch ((a.order, b.order)) { |
chrisbobbe
force-pushed
the
pr-channel-folders
branch
from
84604e0 to
0f96fad
Compare
|
Thanks for the review! Revision pushed. |
It'll be useful to have this encapsulated for when we implement the UI (zulip#1765).
|
Thanks! Looks good; merging. |
gnprice
force-pushed
the
pr-channel-folders
branch
from
0f96fad to
cc2b97e
Compare
3 participants
This PR aims to add all the data we'll need to show channel folders in the inbox, i.e.: