msglist: Softly override mark-read-on-scroll setting in starred/mentions #1659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't so "soft" right now, because we don't offer a way to undo the override -- that's zulip#1655, as the new comment says -- but conceptually this seems correct and seems to match web. We'll do this for search, too, coming up.
chrisbobbe
added
the
integration review
chrisbobbe
force-pushed
the
pr-soft-override-mark-read-scroll-starred-mentions
branch
from
76bf701 to
7eba55f
Compare
gnprice
reviewed
Jul 3, 2025
Comment on lines
+248
to
+251
| case MentionsNarrow(): | ||
| case StarredMessagesNarrow(): | ||
| // TODO(#1583) write tests for this | ||
| _markReadOnScroll = false; |
There was a problem hiding this comment.
Huh, is this really what web does? Even if you have the "Automatically mark messages as read" setting set to "Always"? (If that's either of the other values, then it's as if this were false anyway.)
As I said in the office earlier (probably a bit after you sent this PR), it seems fine to me if choosing "Always" for that setting means always. In particular that was the behavior Zulip web had, with no option to do something else, for a number of years.
In any event I think this isn't a blocker for search. With the default value of the auto-mark-read setting, at "conversations only", it'll have no effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't an existing discussion for this; I just had the idea now and thought I'd send a quick PR. Happy to start a discussion though if helpful.
This isn't so "soft" right now, because we don't offer a way to undo the override -- that's #1655, as the new comment says -- but conceptually this seems correct and seems to match web.
We'll do this for search, too, coming up.