fix: add Directionality for Semantics loading indicator tests

Author: cybernova2

lib/main.dart

@@ -18,5 +18,5 @@ void main() {
   LiveZulipBinding.ensureInitialized();
   NotificationService.instance.start();
   ShareService.start();
-  runApp(ZulipApp());
+  runApp(const ZulipApp());
 }

lib/widgets/action_sheet.dart

@@ -256,11 +256,9 @@ class BottomSheetEmptyContentPlaceholder extends StatelessWidget {
 
     final child = loading
       ? Semantics(
-
+      textDirection: Directionality.of(context),
       focusable: true,
-
       liveRegion: true,
-
       label: 'Loading…',
       child: CircularProgressIndicator(),
     )
@@ -636,6 +634,8 @@ class ChannelFeedButton extends ActionSheetMenuItemButton {
   }
 }
 
+
+
 class CopyChannelLinkButton extends ActionSheetMenuItemButton {
   const CopyChannelLinkButton({
     super.key,

lib/widgets/home.dart

@@ -248,10 +248,10 @@ class _LoadingPlaceholderPageState extends State<_LoadingPlaceholderPage> {
           children: [
             Semantics(
               label: 'Loading…',
+              textDirection: Directionality.of(context),
               liveRegion: true,
               child:const CircularProgressIndicator(),
-            )
-            ,
+            ),
             Visibility(
               visible: showTryAnotherAccount,
               maintainSize: true,

lib/widgets/message_list.dart

@@ -1298,8 +1298,8 @@ class _MessageListLoadingMore extends StatelessWidget {
       child: Padding(
         padding: const EdgeInsets.symmetric(vertical: 16.0),
         child: Semantics(
+          textDirection: Directionality.of(context),
           label: 'Loading more messages',
-
           liveRegion: true,
           child: const CircularProgressIndicator(),
         ),

lib/widgets/topic_list.dart

@@ -170,6 +170,7 @@ class _TopicListState extends State<_TopicList> with PerAccountStoreAwareStateMi
         child: Padding(
           padding: const EdgeInsets.symmetric(vertical: 16.0),
           child: Semantics(
+            textDirection: Directionality.of(context),
             label: 'Loading…',       // plain string (not localized)
             liveRegion: true,
             child: CircularProgressIndicator(),
@@ -179,6 +180,7 @@ class _TopicListState extends State<_TopicList> with PerAccountStoreAwareStateMi
 
     }
 
+
     // TODO(design) handle the rare case when `lastFetchedTopics` is empty
 
     // This is adapted from parts of the build method on [_InboxPageState].

test/widgets/image_test.dart

@@ -21,9 +21,13 @@ void main() {
 
       final httpClient = prepareBoringImageHttpClient();
 
-      await tester.pumpWidget(GlobalStoreWidget(
-        child: PerAccountStoreWidget(accountId: eg.selfAccount.id,
-          child: RealmContentNetworkImage(src))));
+      await tester.pumpWidget( Directionality(
+          textDirection: TextDirection.ltr,
+          child: GlobalStoreWidget(
+            child: PerAccountStoreWidget(
+              accountId: eg.selfAccount.id,
+              child: RealmContentNetworkImage(src),
+            ),)));
       await tester.pump();
       await tester.pump();
 
@@ -47,7 +51,9 @@ void main() {
 
     testWidgets('throws if no `PerAccountStoreWidget` ancestor', (tester) async {
       await tester.pumpWidget(
-        RealmContentNetworkImage(Uri.parse('https://zulip.invalid/path/to/image.png'), filterQuality: FilterQuality.medium));
+        Directionality( textDirection: TextDirection.ltr,
+
+            child: RealmContentNetworkImage(Uri.parse('https://zulip.invalid/path/to/image.png'), filterQuality: FilterQuality.medium)));
       check(tester.takeException()).isA<AssertionError>();
     });
   });