accessibility: Add Semantics to loading indicators so screen readers announce loading

Author: cybernova2

.fvmrc

@@ -0,0 +1,3 @@
+{
+  "flutter": "master"
+}

.gitignore

@@ -53,3 +53,6 @@ app.*.map.json
 
 # Old scaffolding hack
 lib/credential_fixture.dart
+
+# FVM Version Cache
+.fvm/

.vscode/settings.json

@@ -1,23 +1,11 @@
-// Visual Studio Code settings for the zulip-flutter repo.
 {
-  // VS Code formats files on save by default.
-  // Like Flutter itself, we don't use the Dart autoformatter,
-  // so disable that VS Code behavior.
   "[dart]": {
-    // This appears redundant with the all-language setting,
-    // but it's not: if the user's personal config has a Dart-specific
-    // setting, then we need a Dart-specific setting to override it.
     "editor.formatOnSave": false,
     "editor.formatOnType": false,
-    "editor.formatOnPaste": false,
+    "editor.formatOnPaste": false
   },
-
-  // For that matter, don't go reformatting whole files in any language.
   "editor.formatOnSave": false,
-
-  // This much more focused automatic fix is helpful, though.
   "files.trimTrailingWhitespace": true,
-
-  // Suppress the warnings that appear for TODOs throughout the codebase.
   "dart.showTodos": false,
-}
+  "dart.flutterSdkPath": ".fvm/versions/master"
+}

lib/main.dart

@@ -18,5 +18,5 @@ void main() {
   LiveZulipBinding.ensureInitialized();
   NotificationService.instance.start();
   ShareService.start();
-  runApp(const ZulipApp());
+  runApp(ZulipApp());
 }

lib/widgets/action_sheet.dart

@@ -255,7 +255,15 @@ class BottomSheetEmptyContentPlaceholder extends StatelessWidget {
     final designVariables = DesignVariables.of(context);
 
     final child = loading
-      ? CircularProgressIndicator()
+      ? Semantics(
+
+      focusable: true,
+
+      liveRegion: true,
+
+      label: 'Loading…',
+      child: CircularProgressIndicator(),
+    )
       : Text(
           textAlign: TextAlign.center,
           style: TextStyle(

lib/widgets/home.dart

@@ -246,7 +246,12 @@ class _LoadingPlaceholderPageState extends State<_LoadingPlaceholderPage> {
         child: Column(
           mainAxisSize: MainAxisSize.min,
           children: [
-            const CircularProgressIndicator(),
+            Semantics(
+              label: 'Loading…',
+              liveRegion: true,
+              child:const CircularProgressIndicator(),
+            )
+            ,
             Visibility(
               visible: showTryAnotherAccount,
               maintainSize: true,

lib/widgets/message_list.dart

@@ -1029,7 +1029,18 @@ class _MessageListState extends State<MessageList> with PerAccountStoreAwareStat
   Widget build(BuildContext context) {
     final zulipLocalizations = ZulipLocalizations.of(context);
 
-    if (!model.fetched) return const Center(child: CircularProgressIndicator());
+    if (!model.fetched) return Center(
+      child: Padding(
+        padding: const EdgeInsets.symmetric(vertical: 16.0),
+        child: Semantics(
+          label: 'Loading more messages',
+          // Tells TalkBack: this is important, announce it
+          liveRegion: true,
+          child: const CircularProgressIndicator(),
+        ),
+      ),
+    );
+
 
     if (model.items.isEmpty && model.haveNewest && model.haveOldest) {
       final String header;
@@ -1283,10 +1294,18 @@ class _MessageListLoadingMore extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    return const Center(
+    return Center(
       child: Padding(
-        padding: EdgeInsets.symmetric(vertical: 16.0),
-        child: CircularProgressIndicator())); // TODO perhaps a different indicator
+        padding: const EdgeInsets.symmetric(vertical: 16.0),
+        child: Semantics(
+          label: 'Loading more messages',
+
+          liveRegion: true,
+          child: const CircularProgressIndicator(),
+        ),
+      ),
+    );
+    // TODO perhaps a different indicator
   }
 }
 

lib/widgets/store.dart

@@ -355,7 +355,15 @@ class LoadingPlaceholder extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    return const Center(child: CircularProgressIndicator());
+    return Center(
+      child: Semantics(
+        label: 'Loading…',
+        liveRegion: true,
+        focusable: true,
+        child: CircularProgressIndicator(),
+      ),
+    );
+
   }
 }
 

lib/widgets/topic_list.dart

@@ -166,7 +166,17 @@ class _TopicListState extends State<_TopicList> with PerAccountStoreAwareStateMi
   @override
   Widget build(BuildContext context) {
     if (lastFetchedTopics == null) {
-      return const Center(child: CircularProgressIndicator());
+      return Center(
+        child: Padding(
+          padding: const EdgeInsets.symmetric(vertical: 16.0),
+          child: Semantics(
+            label: 'Loading…',       // plain string (not localized)
+            liveRegion: true,
+            child: CircularProgressIndicator(),
+          ),
+        ),
+      );
+
     }
 
     // TODO(design) handle the rare case when `lastFetchedTopics` is empty

pubspec.lock

@@ -622,14 +622,6 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "1.0.5"
-  js:
-    dependency: transitive
-    description:
-      name: js
-      sha256: "53385261521cc4a0c4658fd0ad07a7d14591cf8fc33abbceae306ddb974888dc"
-      url: "https://pub.dev"
-    source: hosted
-    version: "0.7.2"
   json_annotation:
     dependency: "direct main"
     description:
@@ -698,18 +690,18 @@ packages:
     dependency: transitive
     description:
       name: matcher
-      sha256: dc58c723c3c24bf8d3e2d3ad3f2f9d7bd9cf43ec6feaa64181775e60190153f2
+      sha256: "12956d0ad8390bbcc63ca2e1469c0619946ccb52809807067a7020d57e647aa6"
       url: "https://pub.dev"
     source: hosted
-    version: "0.12.17"
+    version: "0.12.18"
   material_color_utilities:
     dependency: transitive
     description:
       name: material_color_utilities
-      sha256: f7142bb1154231d7ea5f96bc7bde4bda2a0945d2806bb11670e30b850d56bdec
+      sha256: "9c337007e82b1889149c82ed242ed1cb24a66044e30979c44912381e9be4c48b"
       url: "https://pub.dev"
     source: hosted
-    version: "0.11.1"
+    version: "0.13.0"
   meta:
     dependency: transitive
     description:
@@ -1079,10 +1071,10 @@ packages:
     dependency: "direct dev"
     description:
       name: test
-      sha256: "8f0eb7fa76b7d05a4f3707e0dbd581babef5b0915ca508b757cf15d0cabb56cb"
+      sha256: "77cc98ea27006c84e71a7356cf3daf9ddbde2d91d84f77dbfe64cf0e4d9611ae"
       url: "https://pub.dev"
     source: hosted
-    version: "1.27.0"
+    version: "1.28.0"
   test_api:
     dependency: "direct dev"
     description:
@@ -1095,10 +1087,10 @@ packages:
     dependency: transitive
     description:
       name: test_core
-      sha256: bad9916601a4f2ef6e4dbc466fb712e4b42cf4917c3fd428b018f51984fce13b
+      sha256: f1072617a6657e5fc09662e721307f7fb009b4ed89b19f47175d11d5254a62d4
       url: "https://pub.dev"
     source: hosted
-    version: "0.6.13"
+    version: "0.6.14"
   timing:
     dependency: transitive
     description: