Skip to content

Conversation

@laurynmm
Copy link
Contributor

@laurynmm laurynmm commented Oct 3, 2024

Fixes the string when there are unmatched_exclude_lines so that the file name and line in the file are shown in the terminal.

Before:
Please remove exclusions for file {fn}: {unmatched_exclude_lines}

After:
Please remove exclusions for web/src/common.ts: $(this).before($("<kbd>").text("Fn"), $("<span>").text(" + ").contents());

@timabbott timabbott merged commit 9be0a32 into zulip:main Oct 9, 2024
5 checks passed
@timabbott
Copy link
Member

Nice, merged, thanks @laurynmm!

@laurynmm laurynmm deleted the fix-custom-rules-if-unmatched-exclude-lines branch October 10, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants