Support using "direct" as message type for private messages (#779) #884
+36
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks! Please go through our guide on submitting a pull request to learn how to present your proposed changes to Zulip, so that your work can be reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using "direct" as the message type when sending private messages via the Zulip Python API CLI.
Key Changes:
• CLI now accepts "direct" as a valid message type (--type direct).
• Automatically translates "direct" → "private" for servers with API feature level < 174 (older servers).
• Keeps "direct" unchanged for newer servers (feature level ≥ 174).
• Logging updated to show the actual message type being sent.
Testing:
• Verified sending messages with "direct" and "private".
• Checked correct fallback for older servers.
Related Issue:
Fixes #779