Automate publishing multiarch images to GHCR (migrate away from Docker Hub) #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klardotsh
changed the title
|
Before I go making the changes to run this workflow using tags instead of the version file, saving this link to a successful CI run which generated this GHCR manifest |
klardotsh
force-pushed
the
klardotsh-multiarch-ghcr
branch
from
d50c312
to
6889479
Compare
In light of recent changes to Docker Hub, move our Docker images into GHCR which integrates more tightly with GitHub flows we already use throughout the Zulip org. Since it's near-trivial to do so at the same time, add officiallly-supported ARM64 builds. Resolves #357.
klardotsh
force-pushed
the
klardotsh-multiarch-ghcr
branch
from
6889479
to
4138977
Compare
alexmv
reviewed
Mar 28, 2023
| # -- Pull policy for Zulip docker image. | ||
| # Ref: https://kubernetes.io/docs/user-guide/images/#pre-pulling-images | ||
| pullPolicy: IfNotPresent | ||
| # -- Zulip image tag (immutable tags are recommended) | ||
| tag: "6.1-0" | ||
| tag: "6.1-1" |
There was a problem hiding this comment.
We now can't do this version bump without a tag, so it needs to come after the PR merges. The commit message needs top be massaged accordingly, I think.
| @@ -86,7 +86,7 @@ spec: | |||
| - name: postgresql-persistent-storage | |||
| mountPath: /var/lib/postgresql | |||
| - name: zulip | |||
| image: zulip/docker-zulip:6.1-0 | |||
| image: ghcr.io/zulip/zulip:6.1-1 | |||
Comment on lines
+14
to
+18
| docker pull ghcr.io/zulip/zulip:6.1-1 | ||
| ``` | ||
|
|
||
| - Current Zulip Server version: `6.1` | ||
| - Current Docker image version: `6.1-1` |
There was a problem hiding this comment.
Let's leave these as 6.1-0 for now, and do a version bump tag separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #390 by building multiarch images in GHCR rather than depending on local workstation builds.
Blockers: https://github.com/orgs/zulip/packages/container/package/zulip needs to be made public, and I need to verify that this repo actually has permissions to push to that registry (while I'm an admin of the registry, I'm not an admin of this repo, so can't double-check the secrets plumbing behind the scenes that I vaguely recall being a thing to do here).